Page MenuHomePhabricator
Differential D6600

[backport#15368] Descriptor checksum
ClosedPublic
Actions

Authored by majcosta on Jun 15 2020, 23:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb455b8d27215: [backport#15368] Descriptor checksum
Summary

https://github.com/bitcoin/bitcoin/pull/15368/commits/3b40bff9880e9ae2817136b7d14989afccfc1937

Partial backport of Core PR15368

Test Plan
ninja check
test_runner.py rpc_scantxoutset.py

Diff Detail

Event Timeline

majcosta created this revision.Jun 15 2020, 23:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 23:39
majcosta requested review of this revision.Jun 15 2020, 23:39
teamcity edited the summary of this revision. (Show Details)Jun 15 2020, 23:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6601: [backport#15368] Add getdescriptorinfo to compute checksum.Jun 15 2020, 23:41
Harbormaster completed remote builds in B11514: Diff 21445.Jun 15 2020, 23:49
Fabien requested changes to this revision.Jun 16 2020, 07:56
Fabien added a subscriber: Fabien.

Only comment nits, otherwise LGTM

src/script/descriptor.cpp
141 ↗(On Diff #21445)

Move comment above

143 ↗(On Diff #21445)

Dito

156 ↗(On Diff #21445)

Dito

158 ↗(On Diff #21445)

Dito

1074 ↗(On Diff #21445)

Dito in this function

src/test/descriptor_tests.cpp
39 ↗(On Diff #21445)

Fix layout

This revision now requires changes to proceed.Jun 16 2020, 07:56
majcosta updated this revision to Diff 21461.Jun 16 2020, 15:56

addressed comments

Harbormaster completed remote builds in B11524: Diff 21461.Jun 16 2020, 16:09
Fabien accepted this revision.Jun 16 2020, 16:42
This revision is now accepted and ready to land.Jun 16 2020, 16:42
Closed by commit rABCb455b8d27215: [backport#15368] Descriptor checksum (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 16 2020, 18:19
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCb455b8d27215: [backport#15368] Descriptor checksum.

Revision Contents
Changeset List

PathSize
src/
script/
13 lines
188 lines
test/
134 lines
test/
functional/
12 lines
test_framework/
67 lines
16 lines

Diff 21461

View Options

src/script/descriptor.h

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/test/descriptor_tests.cpp

Loading...
View Options

test/functional/rpc_scantxoutset.py

Loading...
View Options

test/functional/test_framework/descriptors.py

Loading...
View Options

test/functional/wallet_address_types.py

Loading...