Differential D6609

[backport#15368] Add checksums to descriptors.md
ClosedPublic
Actions

Authored by majcosta on Jun 16 2020, 18:27.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf231fc4aa3d5: [backport#15368] Add checksums to descriptors.md

Summary

https://github.com/bitcoin/bitcoin/pull/15368/commits/fd637be8d21a606e98c037b40b268c4a1fae2244

Depends on D6602

Concludes backport of Core PR15368

Test Plan

none

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15368

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11528
Build 22245: Default Diff Build & Tests	Link to the build
Build 22244: Build without Wallet	Link to the build
Build 22243: Build with clang-10	Link to the build
Build 22242: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 16 2020, 18:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2020, 18:27

majcosta requested review of this revision.Jun 16 2020, 18:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11528: Diff 21468.Jun 16 2020, 18:46

Fabien accepted this revision.Jun 17 2020, 09:05

This revision is now accepted and ready to land.Jun 17 2020, 09:05

rebase

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_preciousblock.py                    | ✓ Passed  | 1 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_psbt.py                             | ✓ Passed  | 46 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_scantxoutset.py                     | ✓ Passed  | 4 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_setban.py                           | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_signmessage.py                      | ✓ Passed  | 0 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_signrawtransaction.py               | ✓ Passed  | 1 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_txoutproof.py                       | ✓ Passed  | 1 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_uptime.py                           | ✓ Passed  | 0 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_users.py                            | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mrpc_whitelist.py                        | ✓ Passed  | 0 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mtool_wallet.py                          | ✓ Passed  | 3 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_abandonconflict.py               | ✓ Passed  | 7 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_address_types.py                 | ✓ Passed  | 12 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_avoidreuse.py                    | ✓ Passed  | 1 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_balance.py                       | ✓ Passed  | 7 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_basic.py                         | ✓ Passed  | 28 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_create_tx.py                     | ✓ Passed  | 0 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_createwallet.py                  | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_createwallet.py --usecli         | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_disable.py                       | ✓ Passed  | 0 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_dump.py                          | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_encryption.py                    | ✓ Passed  | 5 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_groups.py                        | ✓ Passed  | 9 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_hd.py                            | ✓ Passed  | 4 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_import_rescan.py                 | ✓ Passed  | 3 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_import_with_label.py             | ✓ Passed  | 0 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_importmulti.py                   | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_importprunedfunds.py             | ✓ Passed  | 0 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_keypool.py                       | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_keypool_topup.py                 | ✓ Passed  | 2 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_labels.py                        | ✓ Passed  | 1 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_listreceivedby.py                | ✓ Passed  | 30 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_listsinceblock.py                | ✓ Passed  | 3 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_listtransactions.py              | ✓ Passed  | 12 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_multiwallet.py                   | ✓ Passed  | 11 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 13 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 5 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_txn_clone.py                     | ✓ Passed  | 1 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_txn_doublespend.py               | ✓ Passed  | 1 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
[14:57:54] :	 [Step 1/2]  [0m [0;32mwallet_zapwallettxes.py                 | ✓ Passed  | 3 s
[14:57:54] :	 [Step 1/2]  [0m [0;31mabc_p2p_avalanche.py                    | ✖ Failed  | 122 s
[14:57:54] :	 [Step 1/2]  [0m [0;31m [1m
[14:57:54] :	 [Step 1/2] ALL                                     | ✖ Failed  | 692 s (accumulated) 
[14:57:54] :	 [Step 1/2]  [0m [0mRuntime: 231 s
[14:57:54] :	 [Step 1/2] 
[14:57:54] :	 [Step 1/2] FAILED: test/CMakeFiles/check-functional 
[14:57:54] :	 [Step 1/2] cd /work/build-diff/test && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py
[14:57:54] :	 [Step 1/2] ninja: build stopped: subcommand failed.
[14:57:54] :	 [Step 1/2] *** Output of /tmp/sanitizer_logs/*.log.* ***
[14:57:54]W:	 [Step 1/2] ++ print_sanitizers_log
[14:57:54]W:	 [Step 1/2] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[14:57:54]W:	 [Step 1/2] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[14:57:54]W:	 [Step 1/2] ++ cat '/tmp/sanitizer_logs/*.log.*'
[14:57:54]W:	 [Step 1/2] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[14:57:54]W:	 [Step 1/2] cp: cannot stat '/work/build': No such file or directory
[14:57:54]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[14:57:58]W:	 [Step 1/2] Process exited with code 1
[14:57:58]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Harbormaster completed remote builds in B11543: Diff 21486.Jun 17 2020, 14:58

This revision was landed with ongoing or failed builds.Jun 17 2020, 15:52

Closed by commit rABCf231fc4aa3d5: [backport#15368] Add checksums to descriptors.md (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain Why

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCf231fc4aa3d5: [backport#15368] Add checksums to descriptors.md.