Page MenuHomePhabricator
Differential D6727

Fix handling of invalid headers
ClosedPublic
Actions

Authored by deadalnix on Jun 24 2020, 22:57.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC599693863bae: Fix handling of invalid headers
Summary

We only disconnect outbound peers (excluding HB compact block peers and manual
connections) when receiving a CACHED_INVALID header.

This is a partial backport of Core PR15141 : https://github.com/bitcoin/bitcoin/pull/15141/commits/6b34bc6b6f54f85537494cbea3846d5d195a06d9

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.Jun 24 2020, 22:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 22:57
deadalnix requested review of this revision.Jun 24 2020, 22:57
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 22:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D6728: Allow use of state.Invalid() for all reasons.Jun 24 2020, 23:03
Harbormaster completed remote builds in B11692: Diff 21738.Jun 24 2020, 23:18
jasonbcox accepted this revision.Jun 24 2020, 23:59
This revision is now accepted and ready to land.Jun 24 2020, 23:59
Closed by commit rABC599693863bae: Fix handling of invalid headers (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhyJun 25 2020, 12:08
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC599693863bae: Fix handling of invalid headers.

Revision Contents
Changeset List

PathSize
src/
85 lines

Diff 21738

View Options

src/net_processing.cpp

Loading...