[backport#15492] [rpc] remove deprecated generate method
ClosedPublic
Actions

Authored by majcosta on Jun 24 2020, 18:12.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rABC1ad604ee3ee1: [backport#15492] [rpc] remove deprecated generate method

Summary

[rpc] remove deprecated generate method
https://github.com/bitcoin/bitcoin/pull/15492/commits/8bb3e4c487500a580e3e18791b1f4e7dcdd35442

[wallet] remove unused GetScriptForMining
https://github.com/bitcoin/bitcoin/pull/15492/commits/07cae5287c4409e9e597b891899403220905881d

Update: considering this is a testing only RPC and it is blocking a bunch of current stuff (and part of a PR going back to D6269), discussion has been mostly in favor of shipping this a bit over a month ahead of the normal deprecation schedule.

Backport of Core PR15492

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11773
Build 23135: Default Diff Build & Tests	Link to the build
Build 23134: Build without Wallet	Link to the build
Build 23133: Build with clang-10	Link to the build
Build 23132: arc lint + arc unit

Event Timeline

majcosta requested review of this revision.Jun 24 2020, 18:12

majcosta created this revision.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11669: Diff 21706.Jun 24 2020, 18:29

majcosta added a child revision: D6712: [backport#15492 1/2] [rpc] simplify generate RPC.Jun 24 2020, 18:53

Fabien requested changes to this revision.Jun 25 2020, 06:44

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/CMakeLists.txt
450 ↗	(On Diff #21706)	How come that removing stuff leads to added dependency ?
src/wallet/rpcwallet.cpp
3885 ↗	(On Diff #21706)	AFAIK the next release is 0.21.10 :)

This revision now requires changes to proceed.Jun 25 2020, 06:44

Fabien added inline comments.Jun 25 2020, 06:45

src/wallet/rpcwallet.cpp
3885 ↗	(On Diff #21706)	I just notice the [v0.22 ONLY] tag... I think you are trapping yourself into a rebase hell here.

majcosta retitled this revision from [backport#15492] [rpc] remove deprecated generate method [v0.22 ONLY] to [backport#15492] [rpc] remove deprecated generate method.Jun 28 2020, 21:47

majcosta edited the summary of this revision. (Show Details)

majcosta requested review of this revision.Jun 28 2020, 21:50

majcosta marked an inline comment as done.

majcosta added inline comments.

src/CMakeLists.txt
450 ↗	(On Diff #21706)	ScriptErrorString(ScriptError) is defined in the script library and is called by rpc/rawtransaction_util.cpp

deadalnix requested changes to this revision.Jun 29 2020, 00:27

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

doc/release-notes.md
28 ↗	(On Diff #21706)	Rebase
src/CMakeLists.txt
450 ↗	(On Diff #21706)	It is not completely absurd for common to depend on script. The question is, does script depends on common? If so, we might have a problem.