Page MenuHomePhabricator
Differential D6712

[backport#15492 1/2] [rpc] simplify generate RPC
ClosedPublic
Actions

Authored by majcosta on Jun 24 2020, 18:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCdb8bab35b22a: [backport#15492 1/2] [rpc] simplify generate RPC
Summary

Removes dead code from after the generate method was removed

https://github.com/bitcoin/bitcoin/pull/15748/commits/9819ad6d07097ca4df92231e18de0b57313e3b78

Depends on D6710

Partial backport of Core PR15748

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 24 2020, 18:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2020, 18:53
majcosta requested review of this revision.Jun 24 2020, 18:53
teamcity edited the summary of this revision. (Show Details)Jun 24 2020, 18:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11672: Diff 21709.Jun 24 2020, 19:07
majcosta added a child revision: D6714: [backport#15492 2/2] [cleanup] Remove unused CReserveKey.Jun 24 2020, 19:09
majcosta retitled this revision from [backport#15492 1/2] [rpc] simplify generate RPC [v0.22 ONLY] to [backport#15492 1/2] [rpc] simplify generate RPC.Jun 28 2020, 21:50
deadalnix requested changes to this revision.Jun 29 2020, 20:51
deadalnix added a subscriber: deadalnix.

Description is not correct.

This revision now requires changes to proceed.Jun 29 2020, 20:51
majcosta edited the summary of this revision. (Show Details)Jun 29 2020, 21:22
majcosta requested review of this revision.Jun 29 2020, 21:24

sorry about that, fixed now

deadalnix accepted this revision.Jun 30 2020, 22:29
This revision is now accepted and ready to land.Jun 30 2020, 22:29
Closed by commit rABCdb8bab35b22a: [backport#15492 1/2] [rpc] simplify generate RPC (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJun 30 2020, 23:28
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCdb8bab35b22a: [backport#15492 1/2] [rpc] simplify generate RPC.

Revision Contents
Changeset List

PathSize
src/
1 line
rpc/
24 lines

Diff 21916

View Options

src/Makefile.am

Loading...
View Options

src/rpc/mining.h

Loading...
View Options

src/rpc/mining.cpp

Loading...