Page MenuHomePhabricator
Differential D6835

[backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field]
ClosedPublic
Actions

Authored by majcosta on Jul 7 2020, 01:09.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rABC3de58c305738: [backport#19188] test: Avoid overwriting the NodeContext member of the testing…
Summary

NodeContext m_node is already a member of BasicTestingSetup which WalletTestingSetup inherits from via TestingSetup

Turns out Core had done this

Backport of Core PR19188

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 7 2020, 01:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2020, 01:09
majcosta requested review of this revision.Jul 7 2020, 01:09
Harbormaster completed remote builds in B11876: Diff 22041.Jul 7 2020, 01:25
Fabien requested changes to this revision.Jul 7 2020, 06:14
Fabien added a subscriber: Fabien.

Please backport PR19188 instead https://github.com/bitcoin/bitcoin/pull/19188

This revision now requires changes to proceed.Jul 7 2020, 06:14
majcosta updated this revision to Diff 22055.Jul 7 2020, 16:44

backported PR19188

majcosta retitled this revision from [cleanup] remove redundant m_node from wallet_test_fixture.h to [backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field].Jul 7 2020, 16:46
majcosta edited the summary of this revision. (Show Details)
Fabien added a comment.Jul 7 2020, 16:46

Please update the summary accordingly

Harbormaster completed remote builds in B11886: Diff 22055.Jul 7 2020, 17:04
majcosta edited the summary of this revision. (Show Details)Jul 7 2020, 18:26
deadalnix accepted this revision.Jul 8 2020, 00:54
Fabien accepted this revision.Jul 8 2020, 08:55
This revision is now accepted and ready to land.Jul 8 2020, 08:55
Closed by commit rABC3de58c305738: [backport#19188] test: Avoid overwriting the NodeContext member of the testing… (authored by majcosta). · Explain WhyJul 8 2020, 15:36
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC3de58c305738: [backport#19188] test: Avoid overwriting the NodeContext member of the testing….

Revision Contents
Changeset List

PathSize
2 lines
src/
1 line
wallet/
test/
1 line
1 line
1 line

Diff 22079

View Options

configure.ac

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/wallet/test/init_test_fixture.h

Loading...
View Options

src/wallet/test/wallet_test_fixture.h

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...