Differential D6967

[backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex
ClosedPublic
Actions

Authored by majcosta on Jul 17 2020, 20:19.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC3e68843ee4f0: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex

Summary

Prevents BlockManager from having to reference ChainstateActive()
within one of its methods which improves encapsulation and makes
testing easier.

https://github.com/bitcoin/bitcoin/pull/16194/commits/4ed55dfcd7894fd5ba6395f244a17ab1f8e786d4

Depends on D6959

Partial backport of Core PR16194

Test Plan

ninja check && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12052
Build 24005: Default Diff Build & Tests	build-diff
Build 24004: Build without Wallet	build-without-wallet
Build 24003: Build with clang-10	build-clang-10
Build 24002: arc lint + arc unit

Event Timeline

majcosta created this revision.Jul 17 2020, 20:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2020, 20:19

majcosta requested review of this revision.Jul 17 2020, 20:19

Harbormaster completed remote builds in B12052: Diff 22345.Jul 17 2020, 20:32

majcosta added a child revision: D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp.Jul 17 2020, 21:18

Please fix description to tell us what it is about.

This revision now requires changes to proceed.Jul 17 2020, 22:12

fixed link to PR and added one to the Core commit

deadalnix accepted this revision.Jul 17 2020, 23:13

This revision is now accepted and ready to land.Jul 17 2020, 23:13

rebase

Harbormaster completed remote builds in B12871: Diff 23701.Sep 22 2020, 23:10

Closed by commit rABC3e68843ee4f0: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex (authored by James O'Beirne <james.obeirne@gmail.com>, committed by majcosta). · Explain WhySep 22 2020, 23:53

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC3e68843ee4f0: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex.

Revision Contents
Changeset List

Path

Size

src/

validation.h

12 lines

validation.cpp

12 lines

Diff 22345

View Options

src/validation.h