Differential D7038

[backport#16451 1/3][wallet] Move CMerkleTx functions into CWalletTx
ClosedPublic
Actions

Authored by majcosta on Jul 25 2020, 07:14.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCa946805a2411: [backport#16451 1/3][wallet] Move CMerkleTx functions into CWalletTx

Summary

CMerkleTx only exists as a base class for CWalletTx and for wallet file
serialization/deserialization. Move CMerkleTx methods into CWalletTx,
but leave class hierarchy and serialization logic in place.

https://github.com/bitcoin/bitcoin/pull/16451/commits/b3a9d179f23f654b8fba63924bbca5fd31ad4bb0

Partial backport of Core PR16451

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12161
Build 24426: Default Diff Build & Tests	build-diff
Build 24425: Build without Wallet	build-without-wallet
Build 24424: Build with clang-10	build-clang-10
Build 24423: arc lint + arc unit

Event Timeline

majcosta created this revision.Jul 25 2020, 07:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2020, 07:14

majcosta requested review of this revision.Jul 25 2020, 07:14

majcosta added a child revision: D7039: [backport#16451 2/3][wallet] Flatten CWalletTx class hierarchy.

majcosta retitled this revision from [backport#16451][wallet] Move CMerkleTx functions into CWalletTx to [backport#16451 1/3][wallet] Move CMerkleTx functions into CWalletTx.Jul 25 2020, 07:18

Harbormaster completed remote builds in B12158: Diff 22508.Jul 25 2020, 07:30

deadalnix requested changes to this revision.Jul 25 2020, 13:03

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.