[backport#15906] [wallet] Move min_depth and max_depth to coin control
ClosedPublic
Actions

Authored by majcosta on Jul 27 2020, 16:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

extract min & max depth onto coin control (Amiti Uttarwar)

Pull request description:

Refactor AvailableCoins to pull min & max depths from coin control.
Add m_max_depth to coin control to support this.
Addresses issue https://github.com/bitcoin/bitcoin/issues/15823, see thread for further details.

Backport of Core PR15906

Test Plan

ninja check check-functional

Repository

rABC Bitcoin ABC

Branch

pr15906

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12167
Build 24450: Default Diff Build & Tests	build-diff
Build 24449: Build without Wallet	build-without-wallet
Build 24448: Build with clang-10	build-clang-10
Build 24447: arc lint + arc unit

majcosta requested review of this revision.Jul 27 2020, 16:08

majcosta planned changes to this revision.Jul 27 2020, 21:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

@Fabien, that dangling int m_min_depth{0} was part of https://github.com/bitcoin/bitcoin/pull/15557 which we skipped because it's all about RBF and fee bumping

This revision is now accepted and ready to land.Jul 28 2020, 08:56

This revision was automatically updated to reflect the committed changes.