Page MenuHomePhabricator
Differential D7050

[backport#16624 3/4] Modify wallet tx status if has been reorged out
ClosedPublic
Actions

Authored by majcosta on Jul 27 2020, 19:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdb8f22c0635a: [backport#16624 3/4] Modify wallet tx status if has been reorged out
Summary

Add a LockChain method to CWallet to know if we can lock or query
chain state safely.

At tx loading, we rely on chain to know if hashBlock of tx is still
in main chain. If not, we set its status to unconfirmed and reset
its hashBlock/nIndex.

If wallet loaded is the wallet-tool one, all wallet txn will
show up with a height of zero. It doesn't matter as status is not
used by wallet-tool.

We take lock prematurely in CWallet::LoadWallet and CWallet::Verify
to ensure that lock order is respected between cs_main an cs_wallet.

https://github.com/bitcoin/bitcoin/pull/16624/commits/40ede992d97df38282919693dfe851c975c3b1d8

Depends on D7049

Partial backport of Core PR16624

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Jul 27 2020, 19:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2020, 19:20
majcosta requested review of this revision.Jul 27 2020, 19:20
majcosta mentioned this in D7051: [backport#16624 4/4] Add a test wallet_reorgsrestore.
Harbormaster completed remote builds in B12176: Diff 22538.Jul 27 2020, 19:51
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 21:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Jul 28 2020, 09:17
This revision is now accepted and ready to land.Jul 28 2020, 09:17
Closed by commit rABCdb8f22c0635a: [backport#16624 3/4] Modify wallet tx status if has been reorged out (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhyJul 28 2020, 11:04
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCdb8f22c0635a: [backport#16624 3/4] Modify wallet tx status if has been reorged out.
majcosta mentioned this in rABC715386dc1fa1: [backport#16624 4/4] Add a test wallet_reorgsrestore.

Revision Contents
Changeset List

PathSize
src/
wallet/
8 lines
24 lines

Diff 22538

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...