Page MenuHomePhabricator
Differential D7203

[refactor] move Park and InvalidateBlock to CChainState public API
ClosedPublic
Actions

Authored by majcosta on Aug 17 2020, 19:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC85fc9dfe0a61: [refactor] move Park and InvalidateBlock to CChainState public API
Summary

Future PR16849 (D7204) introduces locking m_cs_chainstate to their version of InvalidateBlock. Our codepath for that is shared by ParkBlock, InvalidateBlock and FinalizeBlock, so having all three be members of CChainState (FinalizeBlock already is) makes sense.

Also made UnwindBlock private since it's not supposed to be called by just anyone, rather by stuff that knows what they're doing -, and moved FinalizeBlock implementation to be closer to the other two since that makes more sense.

Test Plan
cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 17 2020, 19:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2020, 19:27
majcosta requested review of this revision.Aug 17 2020, 19:27
teamcity edited the summary of this revision. (Show Details)Aug 17 2020, 19:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta planned changes to this revision.Aug 17 2020, 19:30

removing from the queue until dependencies are on Phab and the big picture makes sense

Harbormaster completed remote builds in B12403: Diff 22924.Aug 17 2020, 19:42
majcosta mentioned this in D6956: [thread safety] prevent double lock of cs_main in calls to CChainState::UnwindBlock.Aug 17 2020, 19:44
majcosta requested review of this revision.Aug 17 2020, 19:57
majcosta edited the summary of this revision. (Show Details)
majcosta added a child revision: D6956: [thread safety] prevent double lock of cs_main in calls to CChainState::UnwindBlock.
deadalnix accepted this revision.Aug 17 2020, 22:14
This revision is now accepted and ready to land.Aug 17 2020, 22:14
Closed by commit rABC85fc9dfe0a61: [refactor] move Park and InvalidateBlock to CChainState public API (authored by majcosta). · Explain WhyAug 18 2020, 12:43
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC85fc9dfe0a61: [refactor] move Park and InvalidateBlock to CChainState public API.
PiRK mentioned this in D9780: Pass mempool reference to chainstate constructor.Jul 13 2021, 20:44
PiRK mentioned this in rABC0158b5aeebf6: Pass mempool reference to chainstate constructor.Jul 15 2021, 09:47

Revision Contents
Changeset List

PathSize
src/
2 lines
rpc/
4 lines
18 lines
66 lines

Diff 22936

View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...