Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC8655e22f37e1: [CI] Allow to configure a post build script

Summary

This diff adds a post_build configuration element which allows for
running an arbitraty script as a step after all the targets are built.
Fixes the build for OSX.

Depends on D7408 and D7409.

Test Plan

Ran the builds locally, excepted IBD which I stopped before the end.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ci_post_build

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12685
Build 25466: Build Diff	build-diff · build-clang-tidy · build-clang-10 · build-without-wallet
Build 25465: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 8 2020, 20:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2020, 20:13

Fabien requested review of this revision.Sep 8 2020, 20:13

Remove now unused common_unix_artifacts template

This seems excessive for longer scripts like build-coverage and build-docs. Doesn't this remove linting for those bash scripts? The shorter ones like check-seeds seems reasonable to me.

This revision now requires changes to proceed.Sep 8 2020, 20:37

Harbormaster completed remote builds in B12673: Diff 23386.Sep 8 2020, 20:52

Harbormaster completed remote builds in B12675: Diff 23388.Sep 8 2020, 21:09

Fabien planned changes to this revision.Sep 9 2020, 10:20

Fabien edited the summary of this revision. (Show Details)Sep 9 2020, 10:30

Fabien added parent revisions: D7409: [CMAKE] Make the doc-rpc target actually generate the rpc docs, D7408: [CMAKE] Add a check rule for the buildbot test.

Fabien removed parent revisions: D7397: [CI] Add an option to select the generator, D7398: [CI] Split the secp256k1 build in parts.

Rebase, extract the coverage upload to teamcity as a script

Harbormaster completed remote builds in B12685: Diff 23411.Sep 9 2020, 10:49

jasonbcox accepted this revision.Sep 9 2020, 21:11

jasonbcox added inline comments.