Page MenuHomePhabricator

[CI] Allow to configure a post build script
ClosedPublic

Authored by Fabien on Sep 8 2020, 20:13.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC8655e22f37e1: [CI] Allow to configure a post build script
Summary

This diff adds a post_build configuration element which allows for
running an arbitraty script as a step after all the targets are built.
Fixes the build for OSX.

Depends on D7408 and D7409.

Test Plan

Ran the builds locally, excepted IBD which I stopped before the end.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_post_build
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12695
Build 25483: Build Diffbuild-clang-10 · build-diff · build-clang-tidy · build-without-wallet
Build 25482: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Sep 8 2020, 20:13

Remove now unused common_unix_artifacts template

jasonbcox requested changes to this revision.Sep 8 2020, 20:37
jasonbcox added a subscriber: jasonbcox.

This seems excessive for longer scripts like build-coverage and build-docs. Doesn't this remove linting for those bash scripts? The shorter ones like check-seeds seems reasonable to me.

This revision now requires changes to proceed.Sep 8 2020, 20:37
Fabien planned changes to this revision.Sep 9 2020, 10:20

Rebase, extract the coverage upload to teamcity as a script

jasonbcox added inline comments.
contrib/teamcity/upload-coverage.sh
17 ↗(On Diff #23411)

Nit: Use the heredoc style so this is more readable and less noisy for future patch review:

cat <<EOF
Usage: $0 target
...
EOF
This revision is now accepted and ready to land.Sep 9 2020, 21:11
This revision was landed with ongoing or failed builds.Sep 10 2020, 08:55
This revision was automatically updated to reflect the committed changes.