Page MenuHomePhabricator
Differential D7458

[lint] update expected circular dependencies
ClosedPublic
Actions

Authored by majcosta on Sep 16 2020, 17:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC24a8de1d3480: [lint] update expected circular dependencies
Summary

aserti3-2d introduced a couple circular deps, this accounts for them

Test Plan
./test/lint/lint-circular-dependencies.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update_circular_dep_linter
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12751
Build 25583: Build Diffbuild-clang-tidy · build-clang-10 · build-diff · build-without-wallet
Build 25582: arc lint + arc unit

Event Timeline

majcosta created this revision.Sep 16 2020, 17:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2020, 17:33
majcosta requested review of this revision.Sep 16 2020, 17:33
Harbormaster completed remote builds in B12751: Diff 23520.Sep 16 2020, 17:45
deadalnix requested changes to this revision.Sep 16 2020, 18:54
deadalnix added a subscriber: deadalnix.

How come arc lint didn't yell at us without this patch? Not really a change request, but this needs to be figure out.

This revision now requires changes to proceed.Sep 16 2020, 18:54
majcosta requested review of this revision.Sep 18 2020, 15:30

@bot build-tsan

deadalnix requested changes to this revision.Sep 18 2020, 23:20

This doesn't really answer the question.

This revision now requires changes to proceed.Sep 18 2020, 23:20
majcosta requested review of this revision.Sep 22 2020, 23:50

talked online, going to run this linter on CI

deadalnix accepted this revision.Sep 23 2020, 00:20
This revision is now accepted and ready to land.Sep 23 2020, 00:20
Closed by commit rABC24a8de1d3480: [lint] update expected circular dependencies (authored by majcosta). · Explain WhySep 23 2020, 00:35
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC24a8de1d3480: [lint] update expected circular dependencies.
Fabien mentioned this in D7535: [CI] Run the circular dependencies linter on CI for each diff.Sep 23 2020, 06:58
Fabien mentioned this in rABC299b79d86a23: [CI] Run the circular dependencies linter on CI for each diff.Sep 23 2020, 14:09

Revision Contents
Changeset List

PathSize
test/
lint/
2 lines

Diff 23520

View Options

test/lint/lint-circular-dependencies.sh

Loading...