Fix passing of coin control in SendMoney()
ClosedPublic
Actions

Authored by jasonbcox on Oct 7 2020, 00:14.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC2fef637bd376: Fix passing of coin control in SendMoney()

Summary

D6367 added coin_control as a param but did not clean this up
properly to use it.

This is not covered by tests at the moment, but a quick look at D7685 and this
patch should fix the test failure in that draft.

Test Plan

ninja check check-functional for sanity

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-cc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13223
Build 26489: Build Diff	build-clang · lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff
Build 26488: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 7 2020, 00:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 00:14

jasonbcox requested review of this revision.Oct 7 2020, 00:14

Harbormaster completed remote builds in B13223: Diff 24319.Oct 7 2020, 00:24

good catch

This revision is now accepted and ready to land.Oct 7 2020, 00:27

Closed by commit rABC2fef637bd376: Fix passing of coin control in SendMoney() (authored by jasonbcox). · Explain WhyOct 7 2020, 01:18

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC2fef637bd376: Fix passing of coin control in SendMoney().

majcosta mentioned this in D7685: [backport#17843] wallet: Reset reused transactions cache.Oct 7 2020, 15:10

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

3 lines

Diff 24319

View Options

Fix passing of coin control in SendMoney()ClosedPublicActions