Page MenuHomePhabricator
Differential D7685

[backport#17843] wallet: Reset reused transactions cache
ClosedPublic
Actions

Authored by majcosta on Sep 30 2020, 19:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC31dc3e9d90f5: [backport#17843] wallet: Reset reused transactions cache
Summary

If a destination is reused we mark the cache of the other transactions going to that destination dirty so they are not accidentally reported as trusted when the cache is hit.

Backport of Core PR17843

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 30 2020, 19:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2020, 19:55
teamcity edited the summary of this revision. (Show Details)Sep 30 2020, 19:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity edited the summary of this revision. (Show Details)Sep 30 2020, 20:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13078: Diff 24070.Sep 30 2020, 20:05
teamcity added a comment.Sep 30 2020, 20:05
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

rpc_help.py                             | ✓ Passed  | 1 s
rpc_invalidateblock.py                  | ✓ Passed  | 6 s
rpc_misc.py                             | ✓ Passed  | 1 s
rpc_named_arguments.py                  | ✓ Passed  | 1 s
rpc_net.py                              | ✓ Passed  | 1 s
rpc_preciousblock.py                    | ✓ Passed  | 1 s
rpc_psbt.py                             | ✓ Passed  | 21 s
rpc_scantxoutset.py                     | ✓ Passed  | 4 s
rpc_setban.py                           | ✓ Passed  | 2 s
rpc_signmessage.py                      | ✓ Passed  | 1 s
rpc_signrawtransaction.py               | ✓ Passed  | 1 s
rpc_txoutproof.py                       | ✓ Passed  | 2 s
rpc_uptime.py                           | ✓ Passed  | 1 s
rpc_users.py                            | ✓ Passed  | 2 s
rpc_whitelist.py                        | ✓ Passed  | 1 s
tool_wallet.py                          | ✓ Passed  | 3 s
wallet_abandonconflict.py               | ✓ Passed  | 11 s
wallet_address_types.py                 | ✓ Passed  | 13 s
wallet_backup.py                        | ✓ Passed  | 48 s
wallet_balance.py                       | ✓ Passed  | 14 s
wallet_basic.py                         | ✓ Passed  | 26 s
wallet_coinbase_category.py             | ✓ Passed  | 1 s
wallet_create_tx.py                     | ✓ Passed  | 6 s
wallet_createwallet.py                  | ✓ Passed  | 2 s
wallet_createwallet.py --usecli         | ✓ Passed  | 2 s
wallet_disable.py                       | ✓ Passed  | 1 s
wallet_dump.py                          | ✓ Passed  | 3 s
wallet_encryption.py                    | ✓ Passed  | 5 s
wallet_groups.py                        | ✓ Passed  | 10 s
wallet_hd.py                            | ✓ Passed  | 5 s
wallet_import_rescan.py                 | ✓ Passed  | 4 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importmulti.py                   | ✓ Passed  | 3 s
wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 2 s
wallet_labels.py                        | ✓ Passed  | 1 s
wallet_listreceivedby.py                | ✓ Passed  | 20 s
wallet_listsinceblock.py                | ✓ Passed  | 4 s
wallet_listtransactions.py              | ✓ Passed  | 21 s
wallet_multiwallet.py                   | ✓ Passed  | 15 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 15 s
wallet_reorgsrestore.py                 | ✓ Passed  | 3 s
wallet_resendwallettransactions.py      | ✓ Passed  | 17 s
wallet_txn_clone.py                     | ✓ Passed  | 3 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 1 s
wallet_zapwallettxes.py                 | ✓ Passed  | 5 s
wallet_avoidreuse.py                    | ✖ Failed  | 3 s

ALL                                     | ✖ Failed  | 757 s (accumulated) 
Runtime: 153 s

FAILED: test/CMakeFiles/check-functional-upgrade-activated 
cd /work/abc-ci-builds/build-diff/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-diff/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-diff/test/log && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests with the next upgrade activated" --junitoutput=/work/abc-ci-builds/build-diff/test/junit/functional_tests_with_the_next_upgrade_activated.xml --with-axionactivation
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: wallet_avoidreuse.py
Bitcoin ABC functional tests with the next upgrade activated: wallet_avoidreuse.py

jasonbcox edited the summary of this revision. (Show Details)Oct 1 2020, 03:22
jasonbcox mentioned this in T1094: Backport transaction cache fixes (PR17843).Oct 6 2020, 21:40
jasonbcox mentioned this in D7792: Fix passing of coin control in SendMoney().Oct 7 2020, 00:14
jasonbcox mentioned this in rABC2fef637bd376: Fix passing of coin control in SendMoney().Oct 7 2020, 01:18
majcosta updated this revision to Diff 24338.Oct 7 2020, 15:10

rebasing onto D7792

Harbormaster completed remote builds in B13237: Diff 24338.Oct 7 2020, 15:27
majcosta published this revision for review.Oct 7 2020, 15:33
majcosta added a child revision: D7801: [backport#17889] wallet: Improve CWallet:MarkDestinationsDirty.Oct 7 2020, 15:34
deadalnix accepted this revision.Oct 7 2020, 18:28
This revision is now accepted and ready to land.Oct 7 2020, 18:28
Closed by commit rABC31dc3e9d90f5: [backport#17843] wallet: Reset reused transactions cache (authored by Fabian Jahr <fjahr@protonmail.com>, committed by majcosta). · Explain WhyOct 7 2020, 18:56
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC31dc3e9d90f5: [backport#17843] wallet: Reset reused transactions cache.

Revision Contents
Changeset List

PathSize
src/
wallet/
10 lines
33 lines
test/
functional/
37 lines

Diff 24355

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_avoidreuse.py

Loading...