Page MenuHomePhabricator
Differential D941

Add test for CWalletTx::GetImmatureCredit() returning stale values.
ClosedPublic
Actions

Authored by deadalnix on Jan 12 2018, 23:48.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING88232d52a914: Add test for CWalletTx::GetImmatureCredit() returning stale values.
rABC88232d52a914: Add test for CWalletTx::GetImmatureCredit() returning stale values.
Summary

Add test for cached immature credit flag not being cleared in
CWalletTx::MarkDirty() bug, which was fixed in
https://github.com/bitcoin/bitcoin/pull/8717, commit a560378.

Bacport of core's PR9359

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletimmaturecredittest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1590
Build 1590: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 12 2018, 23:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2018, 23:48
Harbormaster completed remote builds in B1590: Diff 2474.Jan 12 2018, 23:48
jasonbcox added a subscriber: jasonbcox.Jan 13 2018, 00:47
jasonbcox added inline comments.
src/wallet/test/wallet_tests.cpp
535

Should 50 * COIN be wrapped in Amount() like the Amount(0) is?

deadalnix added inline comments.Jan 13 2018, 00:50
src/wallet/test/wallet_tests.cpp
535

No, COIN is an Amount .

jasonbcox accepted this revision.Jan 13 2018, 00:58
This revision is now accepted and ready to land.Jan 13 2018, 00:58
Closed by commit rABC88232d52a914: Add test for CWalletTx::GetImmatureCredit() returning stale values. (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyJan 13 2018, 01:20
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
24 lines

Diff 2474

View Options

src/wallet/test/wallet_tests.cpp

Loading...