Differential D8123

rpc: Move OuterType enum to header
ClosedPublic
Actions

Authored by deadalnix on Oct 26 2020, 15:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC36af7ba9105c: rpc: Move OuterType enum to header

Summary

This is needed so that it can be used by RPCResult

Also,

rename NAMED_ARG to NONE for generalization.
change RPCArg constructors to initialize the members by moving values

Backport of Core PR17809 [1/2] : https://github.com/bitcoin/bitcoin/pull/17809/commits/fa7d0503d320900e14c4d9bc016d65c7431070bb

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17809-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13679
Build 27384: Build Diff	build-clang-tidy · build-diff · build-clang · lint-circular-dependencies · build-without-wallet · build-debug
Build 27383: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 26 2020, 15:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 26 2020, 15:18

deadalnix requested review of this revision.Oct 26 2020, 15:18

teamcity edited the summary of this revision. (Show Details)Oct 26 2020, 15:18

deadalnix added a child revision: D8124: rpc: Auto-format RPCResult.Oct 26 2020, 15:20

Fabien accepted this revision.Oct 26 2020, 15:28

This revision is now accepted and ready to land.Oct 26 2020, 15:28

Harbormaster completed remote builds in B13679: Diff 25112.Oct 26 2020, 15:30

Closed by commit rABC36af7ba9105c: rpc: Move OuterType enum to header (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyOct 26 2020, 15:38

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC36af7ba9105c: rpc: Move OuterType enum to header.

Revision Contents
Changeset List

Path

Size

src/

rpc/

util.h

43 lines

util.cpp

26 lines

Diff 25112

View Options

src/rpc/util.h