Paths

Table of Contentst

[validation] Remove REJECT code from CValidationState
ClosedPublic
Actions

Authored by PiRK on Oct 29 2020, 17:45.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCaaa6b819c0dd: [validation] Remove REJECT code from CValidationState

Summary

We no longer send BIP 61 REJECT messages, so there's no need to set
a REJECT code in the CValidationState object.

This is a backport of Core PR17004 [3/5]
Commit https://github.com/bitcoin/bitcoin/pull/17004/commits/e9d5a59e34ff2d538d8f5315efd9908bf24d0fdc
Depends on D8182

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13752
Build 27523: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27522: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 29 2020, 17:45

Owners added a reviewer: Restricted Owners Package.Oct 29 2020, 17:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2020, 17:45

PiRK requested review of this revision.Oct 29 2020, 17:45

teamcity edited the summary of this revision. (Show Details)Oct 29 2020, 17:45

PiRK added a child revision: D8184: [validation] Fix REJECT message comments.Oct 29 2020, 17:48

Harbormaster completed remote builds in B13752: Diff 25242.Oct 29 2020, 18:08

deadalnix accepted this revision.Oct 29 2020, 18:20

This revision is now accepted and ready to land.Oct 29 2020, 18:20

PiRK mentioned this in D8182: [logging] Don't log REJECT code when transaction is rejected.Oct 29 2020, 18:22

rebase after moving some functional tests to previous commit D8182

Harbormaster completed remote builds in B13756: Diff 25246.Oct 29 2020, 18:49

Closed by commit rABCaaa6b819c0dd: [validation] Remove REJECT code from CValidationState (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyOct 30 2020, 07:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCaaa6b819c0dd: [validation] Remove REJECT code from CValidationState.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

validation.h

4 lines

consensus/

tx_check.cpp

24 lines

tx_verify.cpp

20 lines

validation.h

27 lines

test/

blockcheck_tests.cpp

1 line

checkpoints_tests.cpp

2 lines

transaction_tests.cpp

1 line

validation.h

11 lines

validation.cpp

104 lines

test/

functional/

abc-mempool-coherence-on-activations.py

2 lines

abc-replay-protection.py

2 lines

abc-segwit-recovery.py

4 lines

abc_wallet_standardness.py

4 lines

mining_prioritisetransaction.py

2 lines

Diff 25242

View Options

src/avalanche/validation.h

View Options

src/consensus/tx_check.cpp

View Options

src/consensus/tx_verify.cpp

View Options

src/consensus/validation.h

View Options

src/test/blockcheck_tests.cpp

View Options

src/test/checkpoints_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

test/functional/abc-mempool-coherence-on-activations.py

View Options

test/functional/abc-replay-protection.py

View Options

test/functional/abc-segwit-recovery.py

View Options

test/functional/abc_wallet_standardness.py

View Options

test/functional/mining_prioritisetransaction.py

[validation] Remove REJECT code from CValidationStateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25242

src/avalanche/validation.h

src/consensus/tx_check.cpp

src/consensus/tx_verify.cpp

src/consensus/validation.h

src/test/blockcheck_tests.cpp

src/test/checkpoints_tests.cpp

src/test/transaction_tests.cpp

src/validation.h

src/validation.cpp

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-replay-protection.py

test/functional/abc-segwit-recovery.py

test/functional/abc_wallet_standardness.py

test/functional/mining_prioritisetransaction.py

[validation] Remove REJECT code from CValidationState
ClosedPublic
Actions

Revision Contents
Changeset List