Page MenuHomePhabricator
Differential D8420

Add email form to landing page and sub pages
ClosedPublic
Actions

Authored by jasonbcox on Nov 15 2020, 01:39.

Details

Reviewers
johnkuney
Fabien
Group Reviewers
Restricted Project
Commits
rABCWEB037f6b044108: Add email form to landing page and sub pages
Summary

As requested from Christabel, adding an email collecting form to the site using Mailerlite.

Inserted their script in the head and added the form to the landing page, releases page and docs page

Test Plan

Submit some test emails and confirm the form is working as intended with Christabel

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
add-form
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14054
Build 28113: arc lint + arc unit

Event Timeline

johnkuney created this revision.Nov 15 2020, 01:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2020, 01:39
johnkuney requested review of this revision.Nov 15 2020, 01:40
Harbormaster completed remote builds in B14054: Diff 25780.Nov 15 2020, 01:40
deadalnix requested changes to this revision.Nov 15 2020, 02:23
deadalnix added a subscriber: deadalnix.

Please edit the diff to use proper description.

This revision now requires changes to proceed.Nov 15 2020, 02:23
johnkuney retitled this revision from add-form to Add email form to landing page and sub pages.Nov 15 2020, 04:12
johnkuney edited the summary of this revision. (Show Details)
johnkuney added a comment.Nov 15 2020, 04:21

Sorry about that. Better?

jasonbcox requested changes to this revision.Nov 15 2020, 10:01
jasonbcox added a subscriber: jasonbcox.

Similar to docindex, is it possible to add this to the page layout instead of the index and release pages directly?

index.html
28

Since this may be reused multiple times, please add it to _includes and include it accordingly.

releases.html
9

This location is bad because it pushes the hero boxes below the fold.

jasonbcox removed a reviewer: deadalnix.Nov 15 2020, 10:01
jasonbcox commandeered this revision.Nov 15 2020, 10:32
jasonbcox edited reviewers, added: johnkuney; removed: jasonbcox.
jasonbcox updated this revision to Diff 25784.Nov 15 2020, 10:41
jasonbcox edited the summary of this revision. (Show Details)

Apply my feedback from earlier

Harbormaster completed remote builds in B14056: Diff 25784.Nov 15 2020, 10:41
jasonbcox updated this revision to Diff 25785.Nov 15 2020, 10:55

Move most of the includes to the footer. This looks better in some cases and puts it on more pages.

Harbormaster completed remote builds in B14057: Diff 25785.Nov 15 2020, 10:55
Fabien accepted this revision.Nov 15 2020, 10:57
This revision is now accepted and ready to land.Nov 15 2020, 10:57
Closed by commit rABCWEB037f6b044108: Add email form to landing page and sub pages (authored by johnkuney, committed by jasonbcox). · Explain WhyNov 15 2020, 10:57
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCWEB037f6b044108: Add email form to landing page and sub pages.

Revision Contents
Changeset List

PathSize
_includes/
11 lines
_layouts/
4 lines
5 lines
5 lines

Diff 25780

View Options

_includes/head.html

Loading...
View Options

_layouts/docindex.html

Loading...
View Options

index.html

Loading...
View Options

releases.html

Loading...