See title.
Details
Details
- Reviewers
bytesofman deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABCf0a9f67f8329: [CashTab] Add Fbt dependencies, init script and intl to App component
npm install & npm start. Followed by npm run test.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- transifex-cashtab
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14271 Build 28519: Build Diff Build 28518: arc lint + arc unit
Event Timeline
Comment Actions
This certainly makes for a small diff since there are no code changes beyond installing npm packages. I think, though, that this makes it irrelevant, and also introduces this linting error:
Compiled with warnings. ./src/index.js Line 9:10: 'T' is defined but never used no-unused-vars
I don't think we gain anything here; revoking this diff would only remove dependencies and not any code.
Going forward:
- Test plan for cashtab changes will probably always be npm install && npm start followed by npm test
- Code change should involve some behavior change, otherwise if we need to revoke the behavior-change diff, we might need to dig this one up too
Comment Actions
Adds fbt dependencies and init script, adds intl on App component (English/Portuguese)
web/cashtab/package-lock.json | ||
---|---|---|
44 | Yes, it is also not maintained anymore, I removed it. |