Differential D8722

[net/refactor] Remove m_addr_fetch member var from CNode
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 12:10.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5b34890d578f: [net/refactor] Remove m_addr_fetch member var from CNode

Summary

Partial backport (12/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/7b322df6296609570e368e5f326979279041c11f

Depends on D8721.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p12

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14473
Build 28910: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28909: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 12:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 12:10

Fabien requested review of this revision.Dec 21 2020, 12:10

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 12:10

Fabien added a child revision: D8723: [net/refactor] Remove fInbound flag from CNode.Dec 21 2020, 12:14

Harbormaster completed remote builds in B14473: Diff 26468.Dec 21 2020, 12:38

PiRK accepted this revision.Dec 21 2020, 13:37

This revision is now accepted and ready to land.Dec 21 2020, 13:37

Closed by commit rABC5b34890d578f: [net/refactor] Remove m_addr_fetch member var from CNode (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5b34890d578f: [net/refactor] Remove m_addr_fetch member var from CNode.

Revision Contents
Changeset List

Path

Size

src/

net.h

5 lines

net.cpp

8 lines

net_processing.cpp

8 lines

Diff 26468

View Options

src/net.h

View Options

src/net.cpp

View Options

[net/refactor] Remove m_addr_fetch member var from CNodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26468

src/net.h

src/net.cpp

src/net_processing.cpp

[net/refactor] Remove m_addr_fetch member var from CNode
ClosedPublic
Actions

Revision Contents
Changeset List