Differential D8730

Apply cfilters review fixups
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 15:29.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC25e87193b5c1: Apply cfilters review fixups

Summary

Partial backport (1/3) of core PR19070:
https://github.com/bitcoin/bitcoin/pull/19070/commits/b3fbc94d4f2937bb682f2766cc9a8d4fde328a3f

Depends on D8729.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19070_p1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14488
Build 28940: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28939: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 15:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 15:29

Fabien requested review of this revision.Dec 21 2020, 15:29

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 15:29

Fabien added a child revision: D8731: [net] Signal NODE_COMPACT_FILTERS if we're serving compact filters..Dec 21 2020, 15:30

Harbormaster completed remote builds in B14485: Diff 26480.Dec 21 2020, 15:48

Rebase

Harbormaster completed remote builds in B14488: Diff 26503.Dec 21 2020, 16:38

PiRK accepted this revision.Dec 21 2020, 17:11

This revision is now accepted and ready to land.Dec 21 2020, 17:11

Closed by commit rABC25e87193b5c1: Apply cfilters review fixups (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyDec 21 2020, 20:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC25e87193b5c1: Apply cfilters review fixups.

Fabien mentioned this in T589: BIP157 & BIP158 backports.Dec 23 2020, 09:48

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

52 lines

test/

functional/

p2p_blockfilters.py

2 lines

Diff 26503

View Options

src/net_processing.cpp