Remove unused config argument from the finalization methods
ClosedPublic
Actions

Authored by Fabien on Jan 6 2021, 14:55.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc75f083fc9b1: Remove unused config argument from the finalization methods

Summary

Both MarkBlockAsFinal() and FindBlockToFinalize() take a Config
which is unused, so remove it.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_finalization_config

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14599
Build 29157: Build Diff	build-debug · build-clang-tidy · build-clang · build-without-wallet · lint-circular-dependencies · build-diff
Build 29156: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 6 2021, 14:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2021, 14:55

Fabien requested review of this revision.Jan 6 2021, 14:55

Harbormaster completed remote builds in B14599: Diff 26687.Jan 6 2021, 15:08

PiRK accepted this revision.Jan 6 2021, 15:19

This revision is now accepted and ready to land.Jan 6 2021, 15:19

Closed by commit rABCc75f083fc9b1: Remove unused config argument from the finalization methods (authored by Fabien). · Explain WhyJan 7 2021, 08:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc75f083fc9b1: Remove unused config argument from the finalization methods.

Revision Contents
Changeset List

Path

Size

src/

validation.h

2 lines

validation.cpp

14 lines

Diff 26687

View Options

src/validation.h