Page MenuHomePhabricator
Differential D8833

[CASHTAB] Update the README
ClosedPublic
Actions

Authored by Fabien on Jan 7 2021, 16:24.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCb07f865c4833: [CASHTAB] Update the README
Summary

This diff fixes some markdown formatting issues.

Test Plan
grip README.md

Check it renders as expected.
Try the instructions.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab_readme
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14640
Build 29239: Build Diff
Build 29238: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 7 2021, 16:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2021, 16:24
Fabien requested review of this revision.Jan 7 2021, 16:24
Harbormaster completed remote builds in B14640: Diff 26747.Jan 7 2021, 16:24
majcosta requested changes to this revision.Jan 7 2021, 16:29
majcosta added a subscriber: majcosta.
majcosta added inline comments.
web/cashtab/README.md
68

missed this

This revision now requires changes to proceed.Jan 7 2021, 16:29
Fabien updated this revision to Diff 26750.Jan 7 2021, 16:40
Fabien edited the summary of this revision. (Show Details)

Don't remove the flag now, will do in another diff

Harbormaster completed remote builds in B14642: Diff 26750.Jan 7 2021, 16:41
Fabien added a child revision: D8834: [CASHTAB] Remove the no longer needed --legacy-peer-deps install flag.Jan 7 2021, 16:42
majcosta accepted this revision.Jan 7 2021, 16:53
This revision is now accepted and ready to land.Jan 7 2021, 16:53
Closed by commit rABCb07f865c4833: [CASHTAB] Update the README (authored by Fabien). · Explain WhyJan 7 2021, 19:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb07f865c4833: [CASHTAB] Update the README.

Revision Contents
Changeset List

PathSize
web/
cashtab/
23 lines

Diff 26747

View Options

web/cashtab/README.md

Loading...