Page MenuHomePhabricator
Differential D8904

[Cashtab] bump extension version to support new backend per D8885
ClosedPublic
Actions

Authored by bytesofman on Jan 13 2021, 15:54.

Details

Reviewers
majcosta
alcipir
Fabien
Group Reviewers
Restricted Project
Commits
rABCbc7dca4a146a: [Cashtab] bump extension version to support new backend per D8885
Summary

Bump extension version as this build will be submitted to chrome store

Test Plan

See Readme for extension test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
extension-version-bump
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14746
Build 29449: Build Diffcashtab-tests
Build 29448: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 13 2021, 15:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2021, 15:55
bytesofman requested review of this revision.Jan 13 2021, 15:55
bytesofman updated this revision to Diff 26926.Jan 13 2021, 15:57

Change "CashTab" to "Cashtab"

Harbormaster completed remote builds in B14746: Diff 26925.Jan 13 2021, 15:57
Harbormaster completed remote builds in B14747: Diff 26926.
majcosta accepted this revision.Jan 13 2021, 16:06
This revision is now accepted and ready to land.Jan 13 2021, 16:06
Fabien requested changes to this revision.Jan 13 2021, 16:08

If you are renaming from CashTab to Cashtab, please make it consistently everywhere.

This revision now requires changes to proceed.Jan 13 2021, 16:08
bytesofman updated this revision to Diff 26927.Jan 13 2021, 16:39

Change CashTab to Cashtab, match version of extension to web app (webapp version is artifact)

bytesofman updated this revision to Diff 26928.Jan 13 2021, 16:41

Keep separate versioning for web-app, deal with this when you have app store versions. For now, web app is distinct from extension, should have own versioning.

Harbormaster completed remote builds in B14748: Diff 26927.Jan 13 2021, 16:41
Harbormaster completed remote builds in B14749: Diff 26928.
bytesofman added a child revision: D8906: [Cashtab] hide scrollbar in extension.Jan 13 2021, 18:40
Fabien accepted this revision.Jan 13 2021, 20:13
This revision is now accepted and ready to land.Jan 13 2021, 20:13
Closed by commit rABCbc7dca4a146a: [Cashtab] bump extension version to support new backend per D8885 (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJan 13 2021, 21:10
This revision was automatically updated to reflect the committed changes.
Joey King <joseph.roy.king@gmail.com> added a commit: rABCbc7dca4a146a: [Cashtab] bump extension version to support new backend per D8885.

Revision Contents
Changeset List

PathSize
web/
cashtab/
extension/
public/
2 lines

Diff 26925

View Options

web/cashtab/extension/public/manifest.json

Loading...