Moving dev dependencies to dev, removing unused deps, updates some of them
ClosedPublic
Actions

Authored by bytesofman on Jan 13 2021, 18:25.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCd188a658d95d: Moving dev dependencies to dev, removing unused deps, updates some of them

Summary

Moves dependencies only required to development to devDependencies. Removes artifact dependencies. Updates some of them.

List of updated modules (to latest version):

babel-plugin-named-asset-import
camelcase
dotenv
lint-staged
prettier
sass-loader
css-loader

The previous issue with css-loader breaking npm start appears to have been resolved by the resolution of the React 16 conflict in earlier diffs and updates to other css dependencies.

Test Plan

npm start

Observe app loads correctly, no errors in console
Send a BCHA tx
Send an SLPA tx
Try copying the address to clipboard by clicking on QR code

Diff Detail

Repository

rABC Bitcoin ABC

Branch

new-dev-dependency-org

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14751
Build 29459: Build Diff	cashtab-tests
Build 29458: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 13 2021, 18:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2021, 18:25

bytesofman requested review of this revision.Jan 13 2021, 18:25

Harbormaster completed remote builds in B14751: Diff 26932.Jan 13 2021, 18:27

For clarity, here are the packages that were removed vs re-orged:

big.js
browser-image-compression
core-util-is
crypto-js
gh-pages
identity-obj-proxy
jdenticon
react-jdenticon
react-swipeable
semver

majcosta requested changes to this revision.Jan 14 2021, 04:01

majcosta added a subscriber: majcosta.

majcosta added inline comments.

web/cashtab/package.json
12	if this version bump was intentional, you should let it be known in the summary. ditto for any others.

This revision now requires changes to proceed.Jan 14 2021, 04:01

Upgrading css-loader and other dependencies

List of updated modules (to latest version):

babel-plugin-named-asset-import
camelcase
dotenv
lint-staged
prettier
sass-loader
css-loader

The previous issue with css-loader breaking npm startappears to have been resolved by the resolution of the React 16 conflict in earlier diffs and updates to other css dependencies.

Harbormaster completed remote builds in B14760: Diff 26945.Jan 14 2021, 10:58

majcosta retitled this revision from Moving dev dependencies to dev, removing unused deps to Moving dev dependencies to dev, removing unused deps, updates some of them.Jan 14 2021, 11:02

majcosta edited the summary of this revision. (Show Details)

majcosta accepted this revision.Jan 14 2021, 11:29

This revision is now accepted and ready to land.Jan 14 2021, 11:29

Closed by commit rABCd188a658d95d: Moving dev dependencies to dev, removing unused deps, updates some of them (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJan 14 2021, 12:40

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCd188a658d95d: Moving dev dependencies to dev, removing unused deps, updates some of them.

bytesofman mentioned this in D8811: [cashtab] Upgrade node modules.Jan 14 2021, 12:45

Fabien mentioned this in D8907: [Cashtab] parse sats from scanned qr code amount param.Jan 14 2021, 19:36