Remove CChainParams parameter from BlockAssembler
ClosedPublic
Actions

Authored by matiu on Jan 24 2018, 20:14.

Details

Reviewers

jasonbcox
deadalnix
schancel

Group Reviewers

Restricted Project

Maniphest Tasks

T169: Remove CChainParams parameter from BlockAssembler

Commits

rSTAGINGd972add4a2d9: Remove CChainParams parameter from BlockAssembler
rABCd972add4a2d9: Remove CChainParams parameter from BlockAssembler

Summary

Remove CChainParams parameter from BlockAssembler

Fixes T169

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

t169

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1754
Build 1754: arc lint + arc unit

Event Timeline

matiu created this revision.Jan 24 2018, 20:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2018, 20:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel accepted this revision.Jan 24 2018, 21:02

This revision is now accepted and ready to land.Jan 24 2018, 21:02

jasonbcox accepted this revision.Jan 24 2018, 21:38

Closed by commit rABCd972add4a2d9: Remove CChainParams parameter from BlockAssembler (authored by matiu). · Explain WhyJan 24 2018, 21:46

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

miner.h

3 lines

miner.cpp

6 lines

rpc/

mining.cpp

7 lines

test/

miner_tests.cpp

93 lines

test_bitcoin.cpp

3 lines

Diff 2731

View Options

src/miner.h

View Options

src/miner.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/miner_tests.cpp

View Options

Remove CChainParams parameter from BlockAssemblerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2731

src/miner.h

src/miner.cpp

src/rpc/mining.cpp

src/test/miner_tests.cpp

src/test/test_bitcoin.cpp

Remove CChainParams parameter from BlockAssembler
ClosedPublic
Actions

Revision Contents
Changeset List