Page MenuHomePhabricator
Differential D1042

Add bitcoin-cli -stdin and -stdinrpcpass + tests
ClosedPublic
Actions

Authored by matiu on Jan 30 2018, 14:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T210: Backport Core P10997 and PR11125: Add bitcoin-cli -stdin and -stdinrpcpass
Commits
rSTAGINGbdb7e995560d: Add bitcoin-cli -stdin and -stdinrpcpass + tests
rABCbdb7e995560d: Add bitcoin-cli -stdin and -stdinrpcpass + tests
Summary

Backport from Core's PR10997 and PR11125

PR10997:

79191f5 Add option -stdinrpcpass to allow RPC password to be read from standa…

and the tests for it:

PR11125:

29e1dfb [test] Add bitcoin-cli -stdin and -stdinrpcpass functional tests (João Barbosa)
ce379b4 [test] Replace check_output with low level version (João Barbosa)
232e3e8 [test] Add assert_raises_process_error to assert process errors (João Barbosa)
5c18a84 [test] Add support for custom arguments to TestNodeCLI (João Barbosa)
e127494 [test] Improve assert_raises_jsonrpc docstring (João Barbosa)
7696841 Fix style in -stdin and -stdinrpcpass handling (João Barbosa)
Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
t210
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1790
Build 1790: arc lint + arc unit

Event Timeline

matiu created this revision.Jan 30 2018, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2018, 14:18
matiu retitled this revision from Summary: Add bitcoin-cli -stdin and -stdinrpcpass functional tests Add support for custom arguments to TestNodeCLI Improve assert_raises_jsonrpc docstring Replace check_output with low level version Add assert_raises_process_error to assert... to Add bitcoin-cli -stdin and -stdinrpcpass functional tests.Jan 30 2018, 14:19
matiu edited the summary of this revision. (Show Details)
teamcity added a subscriber: teamcity.Jan 30 2018, 14:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matiu retitled this revision from Add bitcoin-cli -stdin and -stdinrpcpass functional tests to [WIP] Add bitcoin-cli -stdin and -stdinrpcpass functional tests.Jan 30 2018, 14:21
matiu retitled this revision from [WIP] Add bitcoin-cli -stdin and -stdinrpcpass functional tests to Add bitcoin-cli -stdin and -stdinrpcpass functional tests.Jan 30 2018, 14:34
matiu edited the summary of this revision. (Show Details)
teamcity added a comment.Jan 30 2018, 14:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

deadalnix requested changes to this revision.Jan 30 2018, 21:54
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/bitcoin-cli.cpp
345 ↗(On Diff #2752)

This is not from PR11125

This revision now requires changes to proceed.Jan 30 2018, 21:54
matiu updated this revision to Diff 2771.Jan 30 2018, 23:11
matiu edited the summary of this revision. (Show Details)
  • rm code from bitcoin-cli.cpp from other PR.
matiu updated this revision to Diff 2772.Jan 30 2018, 23:14

formatting bitcoin-cli

teamcity added a comment.Jan 30 2018, 23:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 30 2018, 23:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 30 2018, 23:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

teamcity added a comment.Jan 30 2018, 23:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

matiu updated this revision to Diff 2775.Jan 31 2018, 00:42

add PR10997 changes

teamcity added a comment.Jan 31 2018, 00:43

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matiu retitled this revision from Add bitcoin-cli -stdin and -stdinrpcpass functional tests to Add bitcoin-cli -stdin and -stdinrpcpass + tests.Jan 31 2018, 00:44
matiu edited the summary of this revision. (Show Details)
teamcity added a comment.Jan 31 2018, 01:07

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel edited the summary of this revision. (Show Details)Jan 31 2018, 23:42
schancel edited the test plan for this revision. (Show Details)
schancel added a subscriber: schancel.
schancel added inline comments.
src/bitcoin-cli.cpp
345 ↗(On Diff #2752)

I believe I just landed the patch for this. I had made the task for this a requirement for this PR. Rebasing should address it.

matiu updated this revision to Diff 2789.Feb 1 2018, 01:37
matiu edited the summary of this revision. (Show Details)

rebased

teamcity added a comment.Feb 1 2018, 01:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matiu planned changes to this revision.Feb 1 2018, 01:44
matiu marked 2 inline comments as done.
matiu added inline comments.
src/bitcoin-cli.cpp
345 ↗(On Diff #2752)

PR11125 where the tests for PR10997
Sorry about it. I added PR10997 changed.

matiu requested review of this revision.Feb 1 2018, 01:44
teamcity added a comment.Feb 1 2018, 01:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix accepted this revision.Feb 2 2018, 14:28
This revision is now accepted and ready to land.Feb 2 2018, 14:28
Closed by commit rABCbdb7e995560d: Add bitcoin-cli -stdin and -stdinrpcpass + tests (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by matiu). · Explain WhyFeb 2 2018, 14:31
This revision was automatically updated to reflect the committed changes.
matiu marked an inline comment as done.
PiRK mentioned this in D8105: remove redundant strprintf and add missing sentence in doc.Oct 25 2020, 07:15
PiRK mentioned this in rABCd4280f43d3d2: remove redundant strprintf and add missing sentence in doc.Oct 25 2020, 16:10

Revision Contents
Changeset List

PathSize
src/
19 lines
test/
functional/
29 lines
test_framework/
22 lines
30 lines

Diff 2789

View Options

src/bitcoin-cli.cpp

Loading...
View Options

test/functional/bitcoin_cli.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...