Differential D9410

[SECP256K1] Optimization: use formulas instead of lookup tables for cancelling g bits
ClosedPublic
Actions

Authored by Fabien on Apr 13 2021, 18:33.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCfcf9750a5685: [SECP256K1] Optimization: use formulas instead of lookup tables for cancelling…

Summary

This only seems to be a win on 64-bit platforms, so only do it there.

Partial backport of secp256k1#831:
https://github.com/bitcoin-core/secp256k1/pull/831/commits/b306935ac12bb24fd931d735b4dfc07f707e7447

Depends on D9409.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 13 2021, 18:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2021, 18:33

Fabien requested review of this revision.Apr 13 2021, 18:33

teamcity edited the summary of this revision. (Show Details)Apr 13 2021, 18:33

Fabien added a child revision: D9411: [SECP256K1] Optimization: track f,g limb count and pass to new variable-time update_fg_var.Apr 13 2021, 18:33

Harbormaster completed remote builds in B15505: Diff 28163.Apr 13 2021, 19:50

majcosta accepted this revision.Apr 14 2021, 00:01

This revision is now accepted and ready to land.Apr 14 2021, 00:01

Closed by commit rABCfcf9750a5685: [SECP256K1] Optimization: use formulas instead of lookup tables for cancelling… (authored by Peter Dettman <peter.dettman@gmail.com>, committed by Fabien). · Explain WhyApr 14 2021, 09:18

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfcf9750a5685: [SECP256K1] Optimization: use formulas instead of lookup tables for cancelling….

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

modinv64_impl.h

46 lines

Diff 28178

View Options

src/secp256k1/src/modinv64_impl.h

[SECP256K1] Optimization: use formulas instead of lookup tables for cancelling g bitsClosedPublicActions