Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC7300d7291145: [backport#19304] test: Check that message sends successfully when header is…

Summary

80d4423f997e15780bfa3f91bf4b4bf656b8ea45 Test buffered valid message (Troy Giorshev)

Pull request description:

This PR is a tweak of #19302.  This sends a valid message.

Additionally, this test includes logging in the same vein as #19272.

Depends on D9513

Backport of core#19304

Test Plan

ninja all && ./test/functional/test_runner.py p2p_invalid_messages

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19304

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15711
Build 31326: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 31325: arc lint + arc unit

Event Timeline

majcosta created this revision.May 12 2021, 19:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 19:07

majcosta requested review of this revision.May 12 2021, 19:07

teamcity edited the summary of this revision. (Show Details)May 12 2021, 19:08

Harbormaster completed remote builds in B15702: Diff 28445.May 12 2021, 19:47

majcosta added a child revision: D9515: [backport#19489] test: Fail wait_until early if connection is lost.May 12 2021, 19:48

rebase

Harbormaster completed remote builds in B15711: Diff 28460.May 13 2021, 01:51

PiRK accepted this revision.May 13 2021, 07:28

This revision is now accepted and ready to land.May 13 2021, 07:28

Closed by commit rABC7300d7291145: [backport#19304] test: Check that message sends successfully when header is… (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyMay 13 2021, 12:33

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC7300d7291145: [backport#19304] test: Check that message sends successfully when header is….

[backport#19304] test: Check that message sends successfully when header is split across two buffers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28460

test/functional/p2p_invalid_messages.py

[backport#19304] test: Check that message sends successfully when header is split across two buffersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28460

test/functional/p2p_invalid_messages.py

[backport#19304] test: Check that message sends successfully when header is split across two buffers
ClosedPublic
Actions

Revision Contents
Changeset List