HomePhabricator

[backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter…

Description

[backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups

Summary:
9a40cfc558b3f7fa4fff1270f969582af17479a5 [refactor] use waiting inside disconnect_p2ps (gzhao408)
aeb9fb414e2d000830287d9dd3fed7fc2eb570d2 [test] wait for disconnect_p2ps to be reflected in getpeerinfo (gzhao408)
e81942d2e1288367e8da94adb2b2a88be99e4751 [test] logging and style followups for bloomfilter tests (gzhao408)

Pull request description:

Followup to #19083 which adds bloomfilter-related tests.

1. Make test_node `disconnect_p2ps` wait until disconnection is complete to avoid race conditions (and not place the burden on tests) from MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/19083#discussion_r437383989). And clean up any redundant `wait_until`s in the functional tests.
2. Clean up style + logging in p2p_filter.py and p2p_nobloomfilter_messages.py and jonatack's other [comments](https://github.com/bitcoin/bitcoin/pull/19083#pullrequestreview-428955784)

Backport of core#19252

Depends on D9512

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9513

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jun 17 2020, 10:20
majcostaCommitted on May 13 2021, 12:32
majcostaPushed on May 13 2021, 12:32
Reviewer
Restricted Project
Differential Revision
D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups
Parents
rABCa496d457ee5a: [backport#19260] p2p: disconnect peers that send filterclear + update existing…
Branches
Unknown
Tags
Unknown