Page MenuHomePhabricator
Differential D9563

Turn InvRequestTracker into a template class
ClosedPublic
Actions

Authored by Fabien on May 20 2021, 19:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC44ba9c229f89: Turn InvRequestTracker into a template class
Summary

This makes it possible to use it for tracking proofs and not only
transactions. Only uint256 or subclasses are supported as an InvId
due to the copy constructor.

Next steps are to update the names of the files, variable, comments and
public interfaces from tx to inv.

Depends on D9567.

Test Plan
ninja all check-all
./test/functional/test_runner.py p2p_tx_download
ninja bitcoin-fuzzers

Diff Detail

Event Timeline

Fabien created this revision.May 20 2021, 19:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2021, 19:32
Fabien requested review of this revision.May 20 2021, 19:32
Harbormaster completed remote builds in B15773: Diff 28560.May 20 2021, 19:44
deadalnix requested changes to this revision.May 20 2021, 22:36
deadalnix added a subscriber: deadalnix.

Not really requesting changes, but back on your queue.

src/invrequest.h
487 ↗(On Diff #28560)

What is this?

I'm not saying it's wrong, but if you could point me to an example of what that achieve, that would be fantastic.

This revision now requires changes to proceed.May 20 2021, 22:36
Mengerian added a task: Restricted Maniphest Task.May 21 2021, 17:09
Fabien updated this revision to Diff 28569.May 21 2021, 21:05

Rebase on top of D9567

Fabien edited the summary of this revision. (Show Details)May 21 2021, 21:06
Fabien added a parent revision: D9567: Abstract out the TxRequestTracker public interface.
Fabien edited the summary of this revision. (Show Details)
Fabien removed a parent revision: D9562: Rename public interfaces from Tx to Inv in InvRequestTracker.
Harbormaster completed remote builds in B15780: Diff 28569.May 21 2021, 21:19
Fabien mentioned this in D9560: Rename `tx` to `inv` in the TxRequestTracker.May 21 2021, 21:25
Fabien added a child revision: D9560: Rename `tx` to `inv` in the TxRequestTracker.May 21 2021, 21:26
deadalnix requested changes to this revision.May 26 2021, 15:39
deadalnix added inline comments.
src/txrequest.h
162

template constraints are called concepts, no?

336

All of this can go inline, there is no point declaring it this way.

This revision now requires changes to proceed.May 26 2021, 15:39
Fabien added inline comments.May 26 2021, 18:54
src/txrequest.h
162

Apparently a concept is a set of contraints, so it's both :)
https://en.cppreference.com/w/cpp/language/constraints

Fabien updated this revision to Diff 28620.May 26 2021, 19:04

Inline the templatized wrapper definitions

Harbormaster completed remote builds in B15816: Diff 28620.May 26 2021, 19:18
deadalnix accepted this revision.May 26 2021, 21:35
deadalnix added inline comments.
src/txrequest.h
262 ↗(On Diff #28620)

It's be better to avoid a copy here.

This revision is now accepted and ready to land.May 26 2021, 21:35
Closed by commit rABC44ba9c229f89: Turn InvRequestTracker into a template class (authored by Fabien). · Explain WhyMay 27 2021, 17:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC44ba9c229f89: Turn InvRequestTracker into a template class.

Revision Contents
Changeset List

PathSize
src/
2 lines
test/
fuzz/
2 lines
2 lines
114 lines
73 lines

Diff 28569

View Options

src/net_processing.h

Loading...
View Options

src/test/fuzz/txrequest.cpp

Loading...
View Options

src/test/txrequest_tests.cpp

Loading...
View Options

src/txrequest.h

Loading...
View Options

src/txrequest.cpp

Loading...