Page MenuHomePhabricator

[Cashtab] Patch bug in fee calculation for token creation
ClosedPublic

Authored by bytesofman on May 26 2021, 17:19.

Details

Summary

Bug in how transaction fees are calculated in token creation previously concealed by the high default app fee of 5 sat/byte. Reducing the fee caused token creation txs to fail. Investigating, bug in how default fee applied (should be in base units i.e. sats).

Test Plan

npm test; note unit test has new mock raw hex as previous tx, while valid, did not correspond to app fee setting.
npm start
Create a token

Diff Detail

Repository
rABC Bitcoin ABC
Branch
token-fee-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15814
Build 31528: Build Diffcashtab-tests
Build 31527: arc lint + arc unit