Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC605bfbfce5a9: [avalanche] Add an API to store and retrieve a proof

Summary

We will need to store proofs that we downloaded and retrieve them for
e.g. relaying. The proof storage is done by the peer manager, which acts
as the valid proof pool and creates a new peer for each new proof. The
interface is provided by the processor so the peer manager remains
private.

Depends on D9617.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

getproof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15839
Build 31578: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 31577: arc lint + arc unit

Event Timeline

Fabien created this revision.May 27 2021, 11:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2021, 11:50

Fabien requested review of this revision.May 27 2021, 11:50

Harbormaster completed remote builds in B15828: Diff 28638.May 27 2021, 12:02

deadalnix added a subscriber: deadalnix.May 27 2021, 13:34

deadalnix added inline comments.

src/avalanche/processor.cpp
504 ↗	(On Diff #28638)	You'd want to know from this API if it was added or not, but this isn't what's returned.

deadalnix requested changes to this revision.May 27 2021, 14:05

deadalnix added inline comments.

src/avalanche/processor.h
306 ↗	(On Diff #28638)	What is the lifetime of that pointer? There is no way this is going to work properly while the proof is owned by the PeerManager is it?

This revision now requires changes to proceed.May 27 2021, 14:05

Return an optional proof to get rid of the lifetime issue while keeping the nullable property.
Don't return success if the proof isn't added because already existing, and add test for this case.

Harbormaster completed remote builds in B15839: Diff 28658.May 28 2021, 10:12

Fabien added a child revision: D9582: [avalanche] Answer proof invs with getdata proof requests.May 28 2021, 12:34

I think it's time to start using smart pointers instead of chasing proof copies all around.

This revision now requires changes to proceed.May 28 2021, 13:07

Fabien edited the summary of this revision. (Show Details)May 31 2021, 12:11

Fabien added a parent revision: D9607: [avalanche] Make the peer hold a shared pointer to the proof.

Return a shared pointer to the proof

Harbormaster completed remote builds in B15855: Diff 28677.May 31 2021, 12:28

deadalnix requested changes to this revision.May 31 2021, 15:16

deadalnix added inline comments.