[avalanche] Manage the notfound messages from a proof request
ClosedPublic
Actions

Authored by Fabien on May 28 2021, 13:11.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

Summary

Handle the case of peer sending a notfound in response of a proof
request. We should then select another peer for the download.

Depends on D9582.

Test Plan

ninja all check
./test/functional/test_runner.py p2p_inv_download

Repository

rABC Bitcoin ABC

Branch

avalanche_proof_notfound

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15842
Build 31584: Build Diff	build-diff · lint-circular-dependencies · build-debug · build-without-wallet · build-clang · build-clang-tidy
Build 31583: arc lint + arc unit

Fabien requested review of this revision.May 28 2021, 13:11

deadalnix requested changes to this revision.May 28 2021, 13:15

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/net_processing.cpp
4455	That check literally makes no sense whatsoever. Proof and Txns are mixed together in these messages, how is that possible that they get different limits? Assuming we even want different limits, they are not enforced properly, and it is very unclear to me why we would want to have different limits in this way. None of this makes any sense.