Page MenuHomePhabricator

[avalanche] Manage the notfound messages from a proof request
ClosedPublic

Authored by Fabien on Fri, May 28, 13:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCd86ccb5a2564: [avalanche] Manage the notfound messages from a proof request
Summary

Handle the case of peer sending a notfound in response of a proof
request. We should then select another peer for the download.

Depends on D9582.

Test Plan
ninja all check
./test/functional/test_runner.py p2p_inv_download

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix requested changes to this revision.Fri, May 28, 13:15
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/net_processing.cpp
4455 ↗(On Diff #28661)

That check literally makes no sense whatsoever.

Proof and Txns are mixed together in these messages, how is that possible that they get different limits? Assuming we even want different limits, they are not enforced properly, and it is very unclear to me why we would want to have different limits in this way.

None of this makes any sense.

This revision now requires changes to proceed.Fri, May 28, 13:15
This revision is now accepted and ready to land.Wed, Jun 2, 12:53
Mengerian added a task: Restricted Maniphest Task.Fri, Jun 4, 17:22