Page MenuHomePhabricator
Differential D9610

Make SetMiscWarning() accept bilingual_str argument
ClosedPublic
Actions

Authored by PiRK on May 31 2021, 14:12.

Details

Reviewers
Fabien
majcosta
Group Reviewers
Restricted Project
Commits
rABC1a0013532d61: Make SetMiscWarning() accept bilingual_str argument
Summary

refactor: Make GetWarnings() bilingual_str aware internally

https://github.com/bitcoin/bitcoin/pull/19233/commits/38e33aa481cefbe12c50f344bae190c0d95fb489

Make GetWarnings() return bilingual_str

https://github.com/bitcoin/bitcoin/pull/19233/commits/d1ae7c0355662481a7d181a0a458284936d53eb1

Make SetMiscWarning() accept bilingual_str argument

https://github.com/bitcoin/bitcoin/pull/19233/commits/d49612f98add29066817b7c808b76c2d728948e5

This is a backport of core#19233

Test Plan

ninja all check-all

grep -r SetMiscWarning src/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 31 2021, 14:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2021, 14:12
PiRK requested review of this revision.May 31 2021, 14:12
teamcity edited the summary of this revision. (Show Details)May 31 2021, 14:13
PiRK edited the test plan for this revision. (Show Details)May 31 2021, 14:26
Harbormaster completed remote builds in B15858: Diff 28681.May 31 2021, 14:34
Fabien accepted this revision.May 31 2021, 19:35
This revision is now accepted and ready to land.May 31 2021, 19:35
majcosta requested changes to this revision.May 31 2021, 19:37
majcosta added a subscriber: majcosta.

looks like we're missing something in validation.cpp

src/warnings.cpp
44 ↗(On Diff #28681)

should this be removed? it is removed in the original PR

This revision now requires changes to proceed.May 31 2021, 19:37
PiRK updated this revision to Diff 28686.May 31 2021, 19:54
PiRK edited the test plan for this revision. (Show Details)

remove an unused string in warnings.cpp

Regarding the difference in validation.cpp, I wasn't able to figure out why they have more occurences of SetMiscWarning than we do. I grepped for it, and for the missing AppendWarning function. On git blame it seems like old code that we no longer have, not new code that we haven't backported yet.

majcosta accepted this revision.May 31 2021, 20:03

sounds good

This revision is now accepted and ready to land.May 31 2021, 20:03
Harbormaster completed remote builds in B15862: Diff 28686.May 31 2021, 20:06
Closed by commit rABC1a0013532d61: Make SetMiscWarning() accept bilingual_str argument (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 31 2021, 20:14
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1a0013532d61: Make SetMiscWarning() accept bilingual_str argument.

Revision Contents
Changeset List

PathSize
src/
index/
2 lines
interfaces/
3 lines
2 lines
qt/
7 lines
2 lines
rpc/
3 lines
4 lines
3 lines
test/
4 lines
2 lines
2 lines
9 lines
59 lines

Diff 28692

View Options

src/index/base.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/timedata_tests.cpp

Loading...
View Options

src/timedata.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/warnings.h

Loading...
View Options

src/warnings.cpp

Loading...