Differential D9825

validation: Remove review-only comments + assertions
ClosedPublic
Actions

Authored by PiRK on Jul 20 2021, 16:30.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCe551bfacbff7: validation: Remove review-only comments + assertions

Summary

[META] This is a followup to "validation: Move FindFilesToPrune{,Manual} to BlockManager" removing comments and assertions meant only to show that the change is correct.

This is a backport of core#19927 [6/6]
https://github.com/bitcoin/bitcoin/pull/19927/commits/72a1d5c6f3834e206719ee5121df7727aed5b786

Depends on D9824

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 20 2021, 16:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2021, 16:30

PiRK requested review of this revision.Jul 20 2021, 16:30

teamcity edited the summary of this revision. (Show Details)Jul 20 2021, 16:31

Harbormaster completed remote builds in B16237: Diff 29275.Jul 20 2021, 17:05

majcosta accepted this revision.Jul 20 2021, 19:11

This revision is now accepted and ready to land.Jul 20 2021, 19:11

Closed by commit rABCe551bfacbff7: validation: Remove review-only comments + assertions (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJul 21 2021, 07:18

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe551bfacbff7: validation: Remove review-only comments + assertions.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

43 lines

Diff 29286

View Options

validation: Remove review-only comments + assertionsClosedPublicActions