Page MenuHomePhabricator
Differential D10037

No need to check for duplicate fileids in all dbenvs
ClosedPublic
Actions

Authored by PiRK on Sep 3 2021, 17:10.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC0b1e3bf1a797: No need to check for duplicate fileids in all dbenvs
Summary

Since we have .walletlock in each directory, we don't need the duplicate
fileid checks across all dbenvs as it shouldn't be possible anyways.

This is a backport of core#19335 [4/5]
https://github.com/bitcoin/bitcoin/pull/19335/commits/00f0041351bcd6ddbab110df1189f79ce011e192

Depends on D10036

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sep 3 2021, 17:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2021, 17:10
PiRK requested review of this revision.Sep 3 2021, 17:10
teamcity edited the summary of this revision. (Show Details)Sep 3 2021, 17:10
PiRK added a child revision: D10038: walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase.Sep 3 2021, 17:11
Harbormaster completed remote builds in B16540: Diff 29774.Sep 3 2021, 17:38
deadalnix accepted this revision.Sep 5 2021, 20:02
This revision is now accepted and ready to land.Sep 5 2021, 20:02
PiRK updated this revision to Diff 29794.Sep 6 2021, 12:42

rebase

PiRK updated this revision to Diff 29795.Sep 6 2021, 12:43

rebase

Harbormaster completed remote builds in B16555: Diff 29794.Sep 6 2021, 12:59
Harbormaster completed remote builds in B16556: Diff 29795.Sep 6 2021, 13:03
Closed by commit rABC0b1e3bf1a797: No need to check for duplicate fileids in all dbenvs (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 6 2021, 16:03
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0b1e3bf1a797: No need to check for duplicate fileids in all dbenvs.

Revision Contents
Changeset List

PathSize
src/
wallet/
37 lines
test/
functional/
6 lines

Diff 29794

View Options

src/wallet/bdb.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...