Differential D10055

Cache responses to addr requests
ClosedPublic
Actions

Authored by PiRK on Sep 6 2021, 16:15.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC2d21afd643f8: Cache responses to addr requests

Summary

Prevents a spy from scraping victim's AddrMan by
reconnecting and re-requesting addrs.
This is a backport of core#18991 [3/5]
https://github.com/bitcoin/bitcoin/pull/18991/commits/acd6135b43941fa51d52f5fcdb2ce944280ad01e

Depends on D10054

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16568
Build 32991: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 32990: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 6 2021, 16:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2021, 16:15

PiRK requested review of this revision.Sep 6 2021, 16:15

PiRK added a child revision: D10056: Add addr permission flag enabling non-cached addr sharing.Sep 6 2021, 16:16

teamcity edited the summary of this revision. (Show Details)Sep 6 2021, 16:17

PiRK edited the summary of this revision. (Show Details)Sep 6 2021, 16:19

PiRK added a parent revision: D10054: Remove useless 2500 limit on AddrMan queries.

Harbormaster completed remote builds in B16568: Diff 29819.Sep 6 2021, 16:53

majcosta accepted this revision.Sep 6 2021, 17:06

This revision is now accepted and ready to land.Sep 6 2021, 17:06

Closed by commit rABC2d21afd643f8: Cache responses to addr requests (authored by Gleb Naumenko <naumenko.gs@gmail.com>, committed by PiRK). · Explain WhySep 7 2021, 07:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2d21afd643f8: Cache responses to addr requests.

Revision Contents
Changeset List

Path

Size

src/

net.h

31 lines

net.cpp

15 lines

net_processing.cpp

3 lines

Diff 29819

View Options

src/net.h

View Options

src/net.cpp

View Options

Cache responses to addr requestsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29819

src/net.h

src/net.cpp

src/net_processing.cpp

Cache responses to addr requests
ClosedPublic
Actions

Revision Contents
Changeset List