Page MenuHomePhabricator

refactor: Remove negative lock annotations from globals
ClosedPublic

Authored by PiRK on Sep 23 2021, 09:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC184dbf064fdd: refactor: Remove negative lock annotations from globals
Summary

They only make sense for mutexes that are private members. Until cs_main is a private member the negative annotations should be replaced by excluded annotations, which are optional.

This is a backport of core#21598

Test Plan

With TSAN:

$ git checkout <previous commit hash>
$ ninja &> before.log
$ git checkout pr21598
$ ninja &> after.log
$ grep "negative capability" before.log | wc -l
33
$ grep "negative capability" after.log | wc -l
0

Event Timeline

PiRK requested review of this revision.Sep 23 2021, 09:02

Tail of the build log:

[386/445] Running utility command for check-bitcoin-merkleblock_tests
[387/445] bitcoin: testing finalization_tests
[388/445] Running utility command for check-bitcoin-bip32_tests
[389/445] Running utility command for check-bitcoin-finalization_tests
[390/445] bitcoin: testing sync_tests
[391/445] Running utility command for check-bitcoin-sync_tests
[392/445] bitcoin: testing torcontrol_tests
[393/445] Running utility command for check-bitcoin-torcontrol_tests
[394/445] bitcoin: testing txvalidationcache_tests
[395/445] Running utility command for check-bitcoin-txvalidationcache_tests
[396/445] bitcoin: testing settings_tests
[397/445] Running utility command for check-bitcoin-settings_tests
[398/445] bitcoin: testing streams_tests
[399/445] bitcoin: testing timedata_tests
[400/445] bitcoin: testing cuckoocache_tests
[401/445] Running utility command for check-bitcoin-timedata_tests
[402/445] Running utility command for check-bitcoin-streams_tests
[403/445] Running utility command for check-bitcoin-cuckoocache_tests
[404/445] bitcoin: testing op_reversebytes_tests
[405/445] bitcoin: testing compilerbug_tests
[406/445] bitcoin: testing validation_flush_tests
[407/445] bitcoin: testing checkpoints_tests
[408/445] bitcoin: testing serialize_tests
[409/445] bitcoin: testing radix_tests
[410/445] Running utility command for check-bitcoin-validation_flush_tests
[411/445] Running utility command for check-bitcoin-op_reversebytes_tests
[412/445] Running utility command for check-bitcoin-checkpoints_tests
[413/445] Running utility command for check-bitcoin-compilerbug_tests
[414/445] Running utility command for check-bitcoin-radix_tests
[415/445] Running utility command for check-bitcoin-serialize_tests
[416/445] bitcoin: testing schnorr_tests
[417/445] Running utility command for check-bitcoin-schnorr_tests
[418/445] bitcoin: testing script_standard_tests
[419/445] bitcoin: testing cashaddr_tests
[420/445] Running utility command for check-bitcoin-script_standard_tests
[421/445] bitcoin: testing validationinterface_tests
[422/445] Running utility command for check-bitcoin-cashaddr_tests
[423/445] bitcoin: testing blockstatus_tests
[424/445] Running utility command for check-bitcoin-validationinterface_tests
[425/445] Running utility command for check-bitcoin-blockstatus_tests
[426/445] bitcoin: testing util_tests
[427/445] Running utility command for check-bitcoin-util_tests
[428/445] bitcoin: testing versionbits_tests
[429/445] bitcoin: testing transaction_tests
[430/445] bitcoin: testing wallet_tests
[431/445] Running utility command for check-bitcoin-versionbits_tests
[432/445] Running utility command for check-bitcoin-transaction_tests
[433/445] Running utility command for check-bitcoin-wallet_tests
[434/445] bitcoin: testing crypto_tests
[435/445] Running utility command for check-bitcoin-crypto_tests
[436/445] bitcoin: testing monolith_opcodes_tests
[437/445] Running utility command for check-bitcoin-monolith_opcodes_tests
[438/445] bitcoin: testing blockcheck_tests
[439/445] Running utility command for check-bitcoin-blockcheck_tests
[440/445] bitcoin: testing script_tests
[441/445] Running utility command for check-bitcoin-script_tests
[442/445] bitcoin: testing coins_tests
[443/445] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Sep 23 2021, 10:17

rebase to make unrelated CI failure go away