Differential D10384

[avalanche] Factorize the inflight request timeout handling
ClosedPublic
Actions

Authored by Fabien on Oct 22 2021, 08:57.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC9ed9d3e7a5d5: [avalanche] Factorize the inflight request timeout handling

Summary

This diff extracts a lambda that can be used with any kind of vote items, for now blocks and proofs.

Ref T1854.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_factorize_clear_inflight_request

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17117
Build 34066: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34065: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 22 2021, 08:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2021, 08:58

Fabien requested review of this revision.Oct 22 2021, 08:58

Fabien mentioned this in D10379: [avalanche] Avoid O(n2) when voting on proofs.Oct 22 2021, 09:07

Fabien added a child revision: D10379: [avalanche] Avoid O(n2) when voting on proofs.Oct 22 2021, 09:07

Harbormaster completed remote builds in B17106: Diff 30647.Oct 22 2021, 09:12

deadalnix requested changes to this revision.Oct 26 2021, 21:12

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/avalanche/processor.cpp
639 ↗	(On Diff #30647)	This is taking the lock every time, even when not needed. This is a regression vs the existing code.

This revision now requires changes to proceed.Oct 26 2021, 21:12

deadalnix added inline comments.Oct 26 2021, 21:13

src/avalanche/processor.cpp
636 ↗	(On Diff #30647)	You can use the WITH_LOCK construct now.

Use a more readable WITH_LOCK construct and avoid the lock when not needed by passing the rwcollection instread of the write view to the lambda

Harbormaster completed remote builds in B17117: Diff 30667.Oct 27 2021, 08:24

deadalnix accepted this revision.Oct 27 2021, 14:14

This revision is now accepted and ready to land.Oct 27 2021, 14:14

Closed by commit rABC9ed9d3e7a5d5: [avalanche] Factorize the inflight request timeout handling (authored by Fabien). · Explain WhyOct 27 2021, 14:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9ed9d3e7a5d5: [avalanche] Factorize the inflight request timeout handling.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

49 lines

Diff 30667

View Options

src/avalanche/processor.cpp

[avalanche] Factorize the inflight request timeout handlingClosedPublicActions