Differential D10404

[avalanche] Make `isConflictingProofPreferred` a static function
AbandonedPublic
Actions

Authored by Fabien on Oct 29 2021, 10:25.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Summary

This is a follow-up to D10388. The method no longer needs to be public after D10394.

Ref T1854.

Depends on D10394.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_isconflictingproofpreferred_static

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17143
Build 34117: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34116: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 29 2021, 10:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2021, 10:25

Fabien requested review of this revision.Oct 29 2021, 10:25

Harbormaster completed remote builds in B17143: Diff 30707.Oct 29 2021, 10:40

deadalnix accepted this revision.Nov 1 2021, 23:00

This revision is now accepted and ready to land.Nov 1 2021, 23:00

Fabien planned changes to this revision.Nov 8 2021, 08:05

Fabien mentioned this in D10439: [avalanche] Make `isConflictingProofPreferred` a comparator.Nov 8 2021, 08:09

Fabien mentioned this in rABC5f0c2f9d3060: [avalanche] Make `isConflictingProofPreferred` a comparator.Nov 18 2021, 08:35

Fabien abandoned this revision.Dec 14 2021, 15:58

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.h

3 lines

peermanager.cpp

4 lines

Diff 30707

View Options

src/avalanche/peermanager.h