Page MenuHomePhabricator
Differential D10685

[avalanche] Make send_poll test helper accept optional type argument.
ClosedPublic
Actions

Authored by tyler-smith on Dec 15 2021, 15:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC003f66910c0d: [avalanche] Make send_poll test helper accept optional type argument.
Summary

Allow the send_poll helper to take an option second argument that is the type of inv to
send a poll for.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
TS_add_avatools_sendpoll_type
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17648
Build 35122: Build Diffbuild-clang · build-clang-tidy · build-without-wallet · build-diff · build-debug
Build 35121: arc lint + arc unit

Event Timeline

tyler-smith created this revision.Dec 15 2021, 15:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2021, 15:43
tyler-smith requested review of this revision.Dec 15 2021, 15:43
tyler-smith edited the summary of this revision. (Show Details)Dec 15 2021, 15:48
tyler-smith edited the summary of this revision. (Show Details)
tyler-smith added a child revision: D10387: [avalanche] Add proof-poll responses.
Harbormaster completed remote builds in B17648: Diff 31417.Dec 15 2021, 15:54
tyler-smith added a child revision: D10686: [avalanche] Move block-vote decision into getAvalancheVoteForBlock..Dec 15 2021, 16:05
deadalnix accepted this revision.Dec 15 2021, 17:09
This revision is now accepted and ready to land.Dec 15 2021, 17:09
Fabien added a subscriber: Fabien.Dec 15 2021, 17:12

Can you edit the test plan to run all the tests and format the line as a code block ? You can use ninja check-functional

tyler-smith edited the test plan for this revision. (Show Details)Dec 19 2021, 23:48

Ok, successfully ran ninja check-functional

Closed by commit rABC003f66910c0d: [avalanche] Make send_poll test helper accept optional type argument. (authored by tyler-smith). · Explain WhyDec 20 2021, 15:26
This revision was automatically updated to reflect the committed changes.
tyler-smith added a commit: rABC003f66910c0d: [avalanche] Make send_poll test helper accept optional type argument..

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
5 lines

Diff 31417

View Options

test/functional/test_framework/avatools.py

Loading...