Paths

Table of Contentst

Differential D10750

Move GetDataDir(fNetSpecific) implementation to ArgsManager.
ClosedPublic
Actions

Authored by PiRK on Jan 3 2022, 16:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc50dcf5b67ea: Move GetDataDir(fNetSpecific) implementation to ArgsManager.

Summary

This is a backport of core#21244 [2/8]
https://github.com/bitcoin/bitcoin/pull/21244/commits/1add318704108faa98f5b1b8e9c96d960e9d23a8

Note: due to out of order backport, I also had to remove private: in setup_common.h which is otherwise removed in core#19806.
Depends on D10749

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17774
Build 35374: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35373: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 3 2022, 16:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2022, 16:22

PiRK requested review of this revision.Jan 3 2022, 16:23

teamcity edited the summary of this revision. (Show Details)Jan 3 2022, 16:23

PiRK edited the summary of this revision. (Show Details)Jan 3 2022, 16:24

PiRK added a child revision: D10751: Modify "util_datadir" unit test to not use gArgs..Jan 3 2022, 16:25

Harbormaster completed remote builds in B17774: Diff 31607.Jan 3 2022, 16:42

@bot build-tsan

teamcity awarded a token.Jan 3 2022, 20:28

Fabien accepted this revision.Jan 3 2022, 20:49

This revision is now accepted and ready to land.Jan 3 2022, 20:49

Closed by commit rABCc50dcf5b67ea: Move GetDataDir(fNetSpecific) implementation to ArgsManager. (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhyJan 4 2022, 14:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc50dcf5b67ea: Move GetDataDir(fNetSpecific) implementation to ArgsManager..

Revision Contents
Changeset List

Path

Size

src/

test/

util/

setup_common.h

1 line

util_tests.cpp

8 lines

util/

system.h

17 lines

system.cpp

87 lines

Diff 31607

View Options

src/test/util/setup_common.h

View Options

src/test/util_tests.cpp

View Options

src/util/system.h

View Options

Move GetDataDir(fNetSpecific) implementation to ArgsManager.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31607

src/test/util/setup_common.h

src/test/util_tests.cpp

src/util/system.h

src/util/system.cpp

Move GetDataDir(fNetSpecific) implementation to ArgsManager.
ClosedPublic
Actions

Revision Contents
Changeset List