Page MenuHomePhabricator
Differential D10753

scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp
ClosedPublic
Actions

Authored by PiRK on Jan 3 2022, 16:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0dca7ef835a4: scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp
Summary
-BEGIN VERIFY SCRIPT-
git ls-files src/test/getarg_tests.cpp | xargs sed -i "s/m_args/m_local_args/g";
arc lint
-END VERIFY SCRIPT-

This is a backport of core#21244 [4/8]
https://github.com/bitcoin/bitcoin/pull/21244/commits/55c68e6f011ee604c8a65b9bca668eb4dec452aa

Depends on D10751

Test Plan

ninja check

Diff Detail

Event Timeline

PiRK created this revision.Jan 3 2022, 16:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2022, 16:28
PiRK requested review of this revision.Jan 3 2022, 16:28
PiRK added a child revision: D10755: scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs.Jan 3 2022, 16:30
PiRK added a child revision: D10756: Change GetBlocksDir() to ArgsManager.GetBlocksDirPath()..
teamcity edited the summary of this revision. (Show Details)Jan 3 2022, 16:32
Harbormaster completed remote builds in B17777: Diff 31610.Jan 3 2022, 17:02
Fabien accepted this revision.Jan 3 2022, 20:44
This revision is now accepted and ready to land.Jan 3 2022, 20:44
PiRK updated this revision to Diff 31619.Jan 4 2022, 07:45
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D10751: Modify "util_datadir" unit test to not use gArgs..

rebase: move this before D10572

PiRK removed a parent revision: D10752: BasicTestingSetup: Add ArgsManager..Jan 4 2022, 07:45
PiRK added a child revision: D10752: BasicTestingSetup: Add ArgsManager..Jan 4 2022, 07:47
PiRK removed a child revision: D10756: Change GetBlocksDir() to ArgsManager.GetBlocksDirPath()..Jan 4 2022, 07:50
PiRK removed a child revision: D10755: scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs.
PiRK mentioned this in D10752: BasicTestingSetup: Add ArgsManager..
Harbormaster completed remote builds in B17783: Diff 31619.Jan 4 2022, 08:07
Closed by commit rABC0dca7ef835a4: scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp (authored by PiRK). · Explain WhyJan 4 2022, 14:31
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0dca7ef835a4: scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp.

Revision Contents
Changeset List

PathSize
src/
test/
122 lines

Diff 31619

View Options

src/test/getarg_tests.cpp

Loading...