Differential D10890

net_processing: move PeerManagerImpl into cpp file
ClosedPublic
Actions

Authored by Fabien on Jan 25 2022, 14:15.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC418a3581123e: net_processing: move PeerManagerImpl into cpp file

Summary

Partial backport of core#20811:
https://github.com/bitcoin/bitcoin/pull/20811/commits/e0f2e6d2df7117a8dbf17c63c5149fc53a6fe2b2

This is a move only change. The double namespace is kept to limit later merge conflicts, it's harmless.

Depends on D10887.

Ref T1696.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR20811_p4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18002
Build 35826: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35825: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 25 2022, 14:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 14:15

Fabien requested review of this revision.Jan 25 2022, 14:15

teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 14:17

Fabien added a child revision: D10892: net_processing: move Peer definition to .cpp.Jan 25 2022, 14:25

PiRK accepted this revision.Jan 25 2022, 14:34

This revision is now accepted and ready to land.Jan 25 2022, 14:34

Harbormaster completed remote builds in B18002: Diff 31951.Jan 25 2022, 14:43

Closed by commit rABC418a3581123e: net_processing: move PeerManagerImpl into cpp file (authored by Anthony Towns <aj@erisian.com.au>, committed by Fabien). · Explain WhyJan 25 2022, 14:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC418a3581123e: net_processing: move PeerManagerImpl into cpp file.

PiRK mentioned this in D13322: remove cs_main extern declaration from net_processing.h.Mar 14 2023, 09:32

PiRK mentioned this in rABC29bba42dc009: remove cs_main extern declaration from net_processing.h.Mar 14 2023, 11:48

Revision Contents
Changeset List

Path

Size

src/

net_processing.h

197 lines

net_processing.cpp

194 lines

Diff 31951

View Options

src/net_processing.h