Differential D11340

Add an option to allow for bypassing the network group limit on outbound connections
ClosedPublic
Actions

Authored by Fabien on Apr 12 2022, 19:53.

Details

Reviewers

tyler-smith

Group Reviewers

Restricted Project

Commits

rABCff8072adcb76: Add an option to allow for bypassing the network group limit on outbound…

Summary

This hidden option is intended for testing purpose only. It makes it possible to bypass the network group limitation for outbound connection, designed to prevent from connecting to several peers located in the same area and as such helps preventing eclipse attacks. This new flag comes in handy when running tests in a semi private network made of nodes located at the same place. There is no change of behavior when the flag is not set.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

net_bypass_group_limit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18799
Build 37389: Build Diff	build-diff · lint-circular-dependencies · build-debug · build-without-wallet · build-clang · build-clang-tidy
Build 37388: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 12 2022, 19:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2022, 19:53

Fabien requested review of this revision.Apr 12 2022, 19:53

Harbormaster completed remote builds in B18799: Diff 33178.Apr 12 2022, 20:06

This flag will be useful and the implementation looks correct.

This revision is now accepted and ready to land.Apr 13 2022, 00:38

Closed by commit rABCff8072adcb76: Add an option to allow for bypassing the network group limit on outbound… (authored by Fabien). · Explain WhyApr 13 2022, 08:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCff8072adcb76: Add an option to allow for bypassing the network group limit on outbound….

Fabien mentioned this in D11390: [avalanche] Bypass net group limits by default for avalanche outbounds.Apr 27 2022, 08:47

sdulfari added a subscriber: sdulfari.Apr 28 2022, 21:06

sdulfari added inline comments.

src/init.cpp
399 ↗	(On Diff #33195)	In post review, I find this comment to have aged poorly (example: D11390) I don't think this comment belongs here, but rather where the arg is used.