Page MenuHomePhabricator

[WEBSITE] Add the new IFP address to the upgrade page
ClosedPublic

Authored by Fabien on Apr 21 2022, 12:46.

Details

Summary

Right now the address is only readable in the code, which is not very convenient for pool operators.

Test Plan
bundle exec jekyll serve --incremental

Check the address is correct and the code block looks good with various screen sizes.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
new_ifp_address
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18867
Build 37519: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Apr 21 2022, 12:46
bytesofman added a subscriber: bytesofman.

Rendering issue for widths below 450px:

450px:

image.png (367×497 px, 58 KB)

320px:

image.png (762×379 px, 80 KB)

I think the best available solution is to word wrap the address, which still preserves the original string and doesn't add extra characters like a -.

e.g.

<code style="overflow-wrap: break-word;">ecash:prfhcnyqnl5cgrnmlfmms675w93ld7mvvqd0y8lz07</code>

gives:

image.png (674×375 px, 84 KB)

upgrade.html
15 ↗(On Diff #33270)

Add style="overflow-wrap: break-word;" to the opening <code> tag

This revision now requires changes to proceed.Apr 21 2022, 17:35

Good catch and thanks for the hint.

Fix overflow wrapping of the address for smaller screens

This revision is now accepted and ready to land.Apr 22 2022, 16:27
Mengerian added a subscriber: Mengerian.

Looks good to me too.